Expose more %ArrayPrototype% functions to the public API.

Expose more %ArrayPrototype% functions to the public API.

In addition to Array.prototype.values() which is already exposed, Blink
needs access to entries(), forEach() and keys() to properly set the
corresponding functions in value iterators for WebIDL conformance.

Add a few new entries to NATIVE_CONTEXT_IMPORTED_FIELDS and expand
V8_INTRINSICS_LIST, as well as some API tests for all these new exposed
functions.

BUG=chromium:632935
R=caitp@igalia.com,jochen@chromium.org,verwaest@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2670833008
Cr-Commit-Position: refs/heads/master@{#43017}
Committed: https://chromium.googlesource.com/v8/v8/+/e7b78ac22937f994d35376b38416a5844d6beced

[Raphael Kubo da Costa (rakuco), 2017-02-03 16:13:17]

PTAL.

This is the V8 side of the required changes to make entries(), forEach(), keys()
and values() in WebIDL value iterators be set to the respective functions from
%ArrayProto%. The Blink side will follow once this part lands.

[caitp, 2017-02-03 16:28:32]

On 2017/02/03 16:13:17, Raphael Kubo da Costa (rakuco) wrote:
> PTAL.
> 
> This is the V8 side of the required changes to make entries(), forEach(),
keys()
> and values() in WebIDL value iterators be set to the respective functions from
> %ArrayProto%. The Blink side will follow once this part lands.

lgtm, though the ArrayProto_* methods may be slower than the old C++
forEach/keys/entries defined in Blink due to always being on the slow path.

[Raphael Kubo da Costa (rakuco), 2017-02-03 16:37:19]

Description was changed from

==========
Expose more %ArrayProto% functions to the public API.

In addition to Array.prototype.values() which is already exposed, Blink
needs access to entries(), forEach() and keys() to properly set the
corresponding functions in value iterators for WebIDL conformance.

Add a few new entries to NATIVE_CONTEXT_IMPORTED_FIELDS and expand
V8_INTRINSICS_LIST, as well as some API tests for all these new exposed
functions.

BUG=chromium:632935
R=caitp@igalia.com,jochen@chromium.org,verwaest@chromium.org,yukishiino@chrom...
==========

to

==========
Expose more %ArrayPrototype% functions to the public API.

In addition to Array.prototype.values() which is already exposed, Blink
needs access to entries(), forEach() and keys() to properly set the
corresponding functions in value iterators for WebIDL conformance.

Add a few new entries to NATIVE_CONTEXT_IMPORTED_FIELDS and expand
V8_INTRINSICS_LIST, as well as some API tests for all these new exposed
functions.

BUG=chromium:632935
R=caitp@igalia.com,jochen@chromium.org,verwaest@chromium.org,yukishiino@chrom...
==========

[jochen (gone - plz use gerrit), 2017-02-04 18:14:29]

lgtm

[Yuki, 2017-02-06 08:12:20]

LGTM!!

This is great especially because Array.forEach, etc. are much faster than
Blink's iterators.

[Raphael Kubo da Costa (rakuco), 2017-02-06 10:42:39]

raphael.kubo.da.costa@intel.com changed reviewers:
+ jkummerow@chromium.org, yangguo@chromium.org

[Raphael Kubo da Costa (rakuco), 2017-02-06 10:42:39]

CC'ing a few more src/js owners in case Toon isn't around.

[Raphael Kubo da Costa (rakuco), 2017-02-07 11:08:44]

raphael.kubo.da.costa@intel.com changed reviewers:
+ bmeurer@chromium.org, cbruni@chromium.org

[Raphael Kubo da Costa (rakuco), 2017-02-07 11:08:45]

+bmeurer, cbruni

I'd really appreciate it if someone could take a look at the changes in src/js.
Thanks!

[Jakob Kummerow, 2017-02-07 19:23:59]

lgtm

[Raphael Kubo da Costa (rakuco), 2017-02-07 19:49:22]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-02-07 19:49:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 19:50:54]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[Raphael Kubo da Costa (rakuco), 2017-02-07 19:53:26]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-02-07 19:53:27]

The patchset sent to the CQ was uploaded after l-g-t-m from caitp@igalia.com,
jochen@chromium.org, jkummerow@chromium.org, yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2670833008/#ps20001
(title: "Rebased patch")

[commit-bot: I haz the power, 2017-02-07 19:53:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 20:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 20:13:49]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Raphael Kubo da Costa (rakuco), 2017-02-07 21:16:50]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-02-07 21:17:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 21:42:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486502210688650,
"parent_rev": "029a145fdb35061c0a1ae413532ca9dc62f4cce2", "commit_rev":
"e7b78ac22937f994d35376b38416a5844d6beced"}

[commit-bot: I haz the power, 2017-02-07 21:42:15]

Description was changed from

==========
Expose more %ArrayPrototype% functions to the public API.

In addition to Array.prototype.values() which is already exposed, Blink
needs access to entries(), forEach() and keys() to properly set the
corresponding functions in value iterators for WebIDL conformance.

Add a few new entries to NATIVE_CONTEXT_IMPORTED_FIELDS and expand
V8_INTRINSICS_LIST, as well as some API tests for all these new exposed
functions.

BUG=chromium:632935
R=caitp@igalia.com,jochen@chromium.org,verwaest@chromium.org,yukishiino@chrom...
==========

to

==========
Expose more %ArrayPrototype% functions to the public API.

In addition to Array.prototype.values() which is already exposed, Blink
needs access to entries(), forEach() and keys() to properly set the
corresponding functions in value iterators for WebIDL conformance.

Add a few new entries to NATIVE_CONTEXT_IMPORTED_FIELDS and expand
V8_INTRINSICS_LIST, as well as some API tests for all these new exposed
functions.

BUG=chromium:632935
R=caitp@igalia.com,jochen@chromium.org,verwaest@chromium.org,yukishiino@chrom...

Review-Url: https://codereview.chromium.org/2670833008
Cr-Commit-Position: refs/heads/master@{#43017}
Committed:
https://chromium.googlesource.com/v8/v8/+/e7b78ac22937f994d35376b38416a5844d6...
==========

[commit-bot: I haz the power, 2017-02-07 21:42:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e7b78ac22937f994d35376b38416a5844d6...