MD Settings: Fix bluetooth_page_tests.js in Vulcanized mode.

MD Settings: Fix bluetooth_page_test.js in Vulcanized mode.

The test can't explicitly import load_time_data.js, because in Vulcanized mode
it ends up importing that file twice, whcih throws an error. Also, using
loadTimeData.overrideValues() is a more established way of providing test dummy
test data.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2670833007
Cr-Commit-Position: refs/heads/master@{#447928}
Committed: https://chromium.googlesource.com/chromium/src/+/a6ec659f2418eb03341c3f6e37632804d2b7499d

[dpapad, 2017-02-03 00:35:05]

Description was changed from

==========
MD Settings: Fix bluetooth_page_test.js in Vulcanized mode.

The test can't explicitly import load_time_data.js, because in Vulcanized mode
it ends up importing that file twice, whcih throws an error. Using
loadTimeData.overrideValues() is a more established way of providing test dummy
test data.

BUG=673825
==========

to

==========
MD Settings: Fix bluetooth_page_test.js in Vulcanized mode.

The test can't explicitly import load_time_data.js, because in Vulcanized mode
it ends up importing that file twice, whcih throws an error. Using
loadTimeData.overrideValues() is a more established way of providing test dummy
test data.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-03 00:35:08]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 00:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 01:41:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:41:58]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-02-03 01:47:19]

dpapad@chromium.org changed reviewers:
+ stevenjb@chromium.org

[dpapad, 2017-02-03 01:48:14]

Description was changed from

==========
MD Settings: Fix bluetooth_page_test.js in Vulcanized mode.

The test can't explicitly import load_time_data.js, because in Vulcanized mode
it ends up importing that file twice, whcih throws an error. Using
loadTimeData.overrideValues() is a more established way of providing test dummy
test data.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix bluetooth_page_test.js in Vulcanized mode.

The test can't explicitly import load_time_data.js, because in Vulcanized mode
it ends up importing that file twice, whcih throws an error. Also, using
loadTimeData.overrideValues() is a more established way of providing test dummy
test data.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-03 02:14:18]

Thanks, sorry, I found the bad example from somewhere... anyway, lgtm.

[dpapad, 2017-02-03 02:33:50]

On 2017/02/03 at 02:14:18, stevenjb wrote:
> Thanks, sorry, I found the bad example from somewhere... anyway, lgtm.

Np. I have a 3 more ChromeOS tests failing in Vulcanized mode
(https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...),
so I might be sending similar fixes soon. Thanks for the quick review.

[dpapad, 2017-02-03 02:34:00]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-02-03 02:34:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 04:22:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486089240541370, "parent_rev":
"f0690bd7c2c1f1ff8d7b7ba04e625c823c5a47d2", "commit_rev":
"a6ec659f2418eb03341c3f6e37632804d2b7499d"}

[commit-bot: I haz the power, 2017-02-03 04:23:26]

Description was changed from

==========
MD Settings: Fix bluetooth_page_test.js in Vulcanized mode.

The test can't explicitly import load_time_data.js, because in Vulcanized mode
it ends up importing that file twice, whcih throws an error. Also, using
loadTimeData.overrideValues() is a more established way of providing test dummy
test data.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix bluetooth_page_test.js in Vulcanized mode.

The test can't explicitly import load_time_data.js, because in Vulcanized mode
it ends up importing that file twice, whcih throws an error. Also, using
loadTimeData.overrideValues() is a more established way of providing test dummy
test data.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2670833007
Cr-Commit-Position: refs/heads/master@{#447928}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6ec659f2418eb03341c3f6e3763...
==========

[commit-bot: I haz the power, 2017-02-03 04:23:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6ec659f2418eb03341c3f6e3763...