Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2670823004: ShapeDetection: add UseCounter for TextDetector.detect() calls (Closed)

Created:
3 years, 10 months ago by mcasas
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, haraken, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ShapeDetection: add UseCounter for TextDetector.detect() calls Because is being used as the popularity of [1] bears witness to, and we'd like to measure it. [1] https://twitter.com/Paul_Kinlan/status/824932360231800832 BUG=676124 Review-Url: https://codereview.chromium.org/2670823004 Cr-Commit-Position: refs/heads/master@{#448088} Committed: https://chromium.googlesource.com/chromium/src/+/2e8d7460c4ea005c075a08bc0fc4265ddb827a15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/TextDetector.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
mcasas
foolip@ RS plz
3 years, 10 months ago (2017-02-03 20:20:49 UTC) #4
foolip
lgtm
3 years, 10 months ago (2017-02-03 20:38:45 UTC) #5
mcasas
ericwilligers@ plz RS auto change in histograms.xml
3 years, 10 months ago (2017-02-03 20:59:02 UTC) #8
mcasas
holte@ RS plz auto changes in histograms.xml (ISO ericwilligers bc of timezones)
3 years, 10 months ago (2017-02-03 21:11:31 UTC) #10
Eric Willigers
lgtm Consider adding a test.
3 years, 10 months ago (2017-02-03 21:29:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670823004/1
3 years, 10 months ago (2017-02-03 21:31:12 UTC) #13
Steven Holte
lgtm
3 years, 10 months ago (2017-02-03 22:28:44 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 22:35:39 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e8d7460c4ea005c075a08bc0fc4...

Powered by Google App Engine
This is Rietveld 408576698