Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2670823002: [debugger] remove mirror cache and v8::Debug::GetMirror. (Closed)

Created:
3 years, 10 months ago by Yang
Modified:
3 years, 10 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove mirror cache and v8::Debug::GetMirror. R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2670823002 Cr-Commit-Position: refs/heads/master@{#42893} Committed: https://chromium.googlesource.com/v8/v8/+/8ae463d736c1a85d66babf2593fd4397162a80f0

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -216 lines) Patch
M include/v8-debug.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/debug/debug.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug/debug.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/debug/debug.js View 1 1 chunk +0 lines, -7 lines 0 comments Download
M src/debug/mirrors.js View 1 10 chunks +7 lines, -115 lines 0 comments Download
M src/inspector/debugger-script.js View 4 chunks +3 lines, -6 lines 0 comments Download
M src/inspector/debugger_script_externs.js View 1 chunk +1 line, -6 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-618608.js View 2 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yang
3 years, 10 months ago (2017-02-02 10:08:12 UTC) #1
jgruber
lgtm https://codereview.chromium.org/2670823002/diff/1/src/debug/debug.js File src/debug/debug.js (left): https://codereview.chromium.org/2670823002/diff/1/src/debug/debug.js#oldcode20 src/debug/debug.js:20: var ParseInt = global.parseInt; MirrorType and ParseInt also ...
3 years, 10 months ago (2017-02-02 12:17:16 UTC) #2
Yang
On 2017/02/02 12:17:16, jgruber wrote: > lgtm > > https://codereview.chromium.org/2670823002/diff/1/src/debug/debug.js > File src/debug/debug.js (left): > ...
3 years, 10 months ago (2017-02-02 13:42:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670823002/20001
3 years, 10 months ago (2017-02-02 13:44:59 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 14:22:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8ae463d736c1a85d66babf2593fd4397162...

Powered by Google App Engine
This is Rietveld 408576698