Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2670783005:
[DevTools] rebased inspector/console/console-tests.html (Closed)
|
Created:
3 years, 10 months ago by kozy Modified:
3 years, 10 months ago Reviewers:
luoe CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] rebased inspector/console/console-tests.html
We don't add ':' to console.count() output if label isn't passed.
BUG=688167
R=luoe@chromium.org
TBR=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2670783005
Cr-Commit-Position: refs/heads/master@{#448403}
Committed: https://chromium.googlesource.com/chromium/src/+/85697ebe9a2873ec8935ce8a8b145a918cef52ed
Patch Set 1 #
Messages
Total messages: 28 (16 generated)
Erik, please take a look!
expectations look good, lgtm
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== [DevTools] rebased inspector/console/console-tests.html We don't add ':' to console.count() output if label isn't passed. BUG=688167 R=luoe@chromium.org ========== to ========== [DevTools] rebased inspector/console/console-tests.html We don't add ':' to console.count() output if label isn't passed. BUG=688167 R=luoe@chromium.org TBR=dgozman@chromium.org ==========
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486417352646880, "parent_rev":
"9c67f9e3bb121a7d91b0b36f1f4ab25957ec1f21", "commit_rev":
"85697ebe9a2873ec8935ce8a8b145a918cef52ed"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] rebased inspector/console/console-tests.html We don't add ':' to console.count() output if label isn't passed. BUG=688167 R=luoe@chromium.org TBR=dgozman@chromium.org ========== to ========== [DevTools] rebased inspector/console/console-tests.html We don't add ':' to console.count() output if label isn't passed. BUG=688167 R=luoe@chromium.org TBR=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2670783005 Cr-Commit-Position: refs/heads/master@{#448403} Committed: https://chromium.googlesource.com/chromium/src/+/85697ebe9a2873ec8935ce8a8b14... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/85697ebe9a2873ec8935ce8a8b14... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
