Towards deleting YUV to RGB computation redundancy

ui/gfx/color_transform_unittest.cc

Index: ui/gfx/color_transform_unittest.cc
diff --git a/ui/gfx/color_transform_unittest.cc b/ui/gfx/color_transform_unittest.cc
index 63ba82a8bf6942222f6bd9134bc3f92c6cdcb4c2..3fc43c2b239b45462fd91eb46f56ca2959bb8427 100644
--- a/ui/gfx/color_transform_unittest.cc
+++ b/ui/gfx/color_transform_unittest.cc
@@ -172,18 +172,6 @@ TEST(SimpleColorSpace, UnknownToSRGB) {
   EXPECT_GT(tmp.z(), tmp.y());
 }
 
-class MatrixTest : public testing::TestWithParam<ColorSpace::MatrixID> {};
-
-TEST_P(MatrixTest, checkInvertible) {

[hubbe, 2017/02/02 04:51:37]

Add color_space_unittest.cc and add this test there?

[ccameron, 2017/02/02 17:33:52]

It's probably more important to ensure that the matrices are correct than that
they are invertible (esp considering how long it took to track down the
SMPTE170M error).

Once we have this plumbed through, we'll want to add some sample ->XYZD50-linear
data points.

[hubbe, 2017/02/02 18:35:25]

I'd prefer to add some tests now, especially since this CL corrects some bugs.
Those bugs should be covered by tests.

-  EXPECT_EQ(GetTransferMatrix(GetParam()).matrix().get(3, 3), 1.0f);
-  // Check that all transfer matrices are invertable.
-  EXPECT_TRUE(GetTransferMatrix(GetParam()).IsInvertible());
-};
-
-INSTANTIATE_TEST_CASE_P(ColorSpace,
-                        MatrixTest,
-                        testing::ValuesIn(all_matrices));
-
 class TransferTest : public testing::TestWithParam<ColorSpace::TransferID> {};
 
 TEST_P(TransferTest, basicTest) {