Towards deleting YUV to RGB computation redundancy

ui/gfx/color_transform_unittest.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/color_space.h"
 #include "ui/gfx/color_transform.h"
 #include "ui/gfx/icc_profile.h"
 #include "ui/gfx/test/icc_profiles.h"
@@ skipping 154 matching lines @@
   EXPECT_NEAR(tmp.y(), 1.0f, 0.001f);
   EXPECT_NEAR(tmp.z(), 1.0f, 0.001f);
 
   // Test a blue color
   tmp = ColorTransform::TriStim(128.0f / 255.0f, 240.0f / 255.0f, 0.5f);
   t->transform(&tmp, 1);
   EXPECT_GT(tmp.z(), tmp.x());
   EXPECT_GT(tmp.z(), tmp.y());
 }
 
-class MatrixTest : public testing::TestWithParam<ColorSpace::MatrixID> {};
-
-TEST_P(MatrixTest, checkInvertible) {

[hubbe, 2017/02/02 04:51:37]

Add color_space_unittest.cc and add this test there?

[ccameron, 2017/02/02 17:33:52]

It's probably more important to ensure that the matrices are correct than that
they are invertible (esp considering how long it took to track down the
SMPTE170M error).

Once we have this plumbed through, we'll want to add some sample ->XYZD50-linear
data points.

[hubbe, 2017/02/02 18:35:25]

I'd prefer to add some tests now, especially since this CL corrects some bugs.
Those bugs should be covered by tests.

-  EXPECT_EQ(GetTransferMatrix(GetParam()).matrix().get(3, 3), 1.0f);
-  // Check that all transfer matrices are invertable.
-  EXPECT_TRUE(GetTransferMatrix(GetParam()).IsInvertible());
-};
-
-INSTANTIATE_TEST_CASE_P(ColorSpace,
-                        MatrixTest,
-                        testing::ValuesIn(all_matrices));
-
 class TransferTest : public testing::TestWithParam<ColorSpace::TransferID> {};
 
 TEST_P(TransferTest, basicTest) {
   for (float x = 0.0f; x <= 1.0f; x += 1.0f / 128.0f) {
     float linear = ColorTransform::ToLinearForTesting(GetParam(), x);
     float x2 = ColorTransform::FromLinearForTesting(GetParam(), linear);
     EXPECT_NEAR(x, x2, 0.001f);
   }
 }
 
@@ skipping 65 matching lines @@
 
 INSTANTIATE_TEST_CASE_P(
     C,
     ColorSpaceTest,
     testing::Combine(testing::ValuesIn(all_primaries),
                      testing::Values(ColorSpace::TransferID::BT709),
                      testing::ValuesIn(all_matrices),
                      testing::ValuesIn(all_ranges),
                      testing::ValuesIn(intents)));
 }  // namespace