Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2670763003:
[turbofan] Run checkpoint elimination early. (Closed)
|
Created:
3 years, 10 months ago by Michael Starzinger Modified:
3 years, 10 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Run checkpoint elimination early.
This runs the existing checkpoint elimination during the "inlining"
optimization phase. It will eliminate redundant checkpoint nodes and
hence reduce graph size earlier. After this change the reducer in
question runs during {InliningPhase} as well as {TypedLoweringPhase}.
R=bmeurer@chromium.org
Review-Url: https://codereview.chromium.org/2670763003
Cr-Commit-Position: refs/heads/master@{#42918}
Committed: https://chromium.googlesource.com/v8/v8/+/87e53cb85ae871b8f95dd19058cac438c57aa751
Patch Set 1 #Patch Set 2 : Rebased. #
Messages
Total messages: 18 (14 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/20390) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/16788) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/22029) v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bmeurer@chromium.org changed reviewers: + bmeurer@chromium.org
lgtm
Thanks. Landing.
Description was changed from ========== [turbofan] Run checkpoint elimination early. R= ========== to ========== [turbofan] Run checkpoint elimination early. R=bmeurer@chromium.org ==========
Description was changed from ========== [turbofan] Run checkpoint elimination early. R=bmeurer@chromium.org ========== to ========== [turbofan] Run checkpoint elimination early. This runs the existing checkpoint elimination during the "inlining" optimization phase. It will eliminate redundant checkpoint nodes and hence reduce graph size earlier. After this change the reducer in question runs during {InliningPhase} as well as {TypedLoweringPhase}. R=bmeurer@chromium.org ==========
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486116982745900,
"parent_rev": "ac187c03230980c4bb8950851d8f2bbda78d3cd2", "commit_rev":
"87e53cb85ae871b8f95dd19058cac438c57aa751"}
Message was sent while issue was closed.
Description was changed from
==========
[turbofan] Run checkpoint elimination early.
This runs the existing checkpoint elimination during the "inlining"
optimization phase. It will eliminate redundant checkpoint nodes and
hence reduce graph size earlier. After this change the reducer in
question runs during {InliningPhase} as well as {TypedLoweringPhase}.
R=bmeurer@chromium.org
==========
to
==========
[turbofan] Run checkpoint elimination early.
This runs the existing checkpoint elimination during the "inlining"
optimization phase. It will eliminate redundant checkpoint nodes and
hence reduce graph size earlier. After this change the reducer in
question runs during {InliningPhase} as well as {TypedLoweringPhase}.
R=bmeurer@chromium.org
Review-Url: https://codereview.chromium.org/2670763003
Cr-Commit-Position: refs/heads/master@{#42918}
Committed:
https://chromium.googlesource.com/v8/v8/+/87e53cb85ae871b8f95dd19058cac438c57...
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/87e53cb85ae871b8f95dd19058cac438c57... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
