[MD History] Vulcanize as part of GN build.

chrome/browser/resources/vulcanize.gni

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 template("vulcanize") {
   action(target_name) {
     script = "//chrome/browser/resources/vulcanize_gn.py"
 
     # Declare dependencies to all involved tools.
     inputs = [
@@ skipping 32 matching lines @@
       invoker.js_out_file,
       "--input_type",
       invoker.input_type,
       "--input",
       invoker.input,
       "--out_folder",
       rebase_path(target_gen_dir, root_build_dir),
       "--depfile",
       rebase_path(depfile, root_build_dir),
     ]
+
+    if (defined(invoker.excludes)) {
+      foreach(_exclude, invoker.excludes) {
+        args += [
+          "--exclude",
+          "$_exclude",
+        ]
+      }
+    }
   }
 }
+
+template("css_build") {

[dpapad, 2017/02/02 18:29:14]

Can we move this to its own css_build.gni now that the logic has been moved to a
separate python script?

+  action(target_name) {
+    script = "//chrome/browser/resources/css_build_gn.py"
+    inputs = [
+      "//third_party/node/node_modules.tar.gz.sha1",
+    ]
+
+    if (is_linux) {
+      inputs += [ "//third_party/node/linux/node-linux-x64.tar.gz.sha1" ]
+    }
+    if (is_win) {
+      inputs += [ "//third_party/node/win/node.exe.sha1" ]
+    }
+    if (is_mac) {
+      inputs += [ "//third_party/node/mac/node-darwin-x64.tar.gz.sha1" ]
+    }

[calamity, 2017/02/02 04:24:05]

I'm not sure how to share this logic between this and the vulcanize template.

I was thinking of doing a base template("node") with an action but then I'd have
to copy all of the properties out of invoker...

Any ideas?

[Dan Beam, 2017/02/02 17:14:52]

i think it might be worthwhile to make a "all things node" template and track
all inputs that might affect node.

perhaps a little simpler (for now): is it possible to hoist this logic out of
both rules to the top of this file and just append a common list of inputs to
both vulcanize / css_build?

node_inputs = []
if (is_linux) { node_inputs += [...] }
if (is_win) { node_inputs += [...] }
if (is_mac) { node_inputs += [...] }

template("vulcanize") {
  inputs = node_inputs
  ...
}

i don't know GN super well.  it looks like Python but isn't.

[dpapad, 2017/02/02 18:18:15]

"All thing node" template was implemented at
https://codereview.chromium.org/2533153002. I never landed this (or sent for
review), but I can revive it if you think is useful.

+    foreach(_input, invoker.input_files) {
+      inputs += [ "$target_gen_dir/$_input" ]
+    }
+
+    outputs = []
+    foreach(_output, invoker.output_files) {
+      outputs += [ "$target_gen_dir/$_output" ]
+    }
+    deps = invoker.deps
+
+    args = [
+             "--out_folder",
+             rebase_path(target_gen_dir, root_build_dir),
+             "--input_files",
+           ] + invoker.input_files + [ "--output_files" ] + invoker.output_files
+  }
+}