Issue 2533153002: DO NOT SUBMIT, call node from GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2533153002: DO NOT SUBMIT, call node from GN.

Created:
4 years ago by dpapad

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DO NOT SUBMIT, call node from GN. BUG= TEST=ninja -C out/gn/ chrome

Patch Set 1 : Remove file. #

Patch Set 2 : add missing file #

Patch Set 3 : Run different scripts with nodejs() #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
M	chrome/browser/ui/BUILD.gn	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/plugins/BUILD.gn	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/plugins/script1.js	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/plugins/script2.js	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	third_party/node/run_node.gni	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download
A	third_party/node/run_node.py	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dpapad

4 years ago (2016-11-29 00:03:59 UTC) #2

Description was changed from

==========
DO NOT SUBMIT, call node from GN.

BUG=
==========

to

==========
DO NOT SUBMIT, call node from GN.

BUG=
TEST=ninja -C out/gn/ chrome
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages