Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 26707004: Hold URLRequestContextGetter by scoped_refptr in Drive related code. (Closed)

Created:
7 years, 2 months ago by kinaba
Modified:
7 years, 2 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Hold URLRequestContextGetter by scoped_refptr in Drive related code. There's little point to hold the refcounted object in a raw pointer. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/browser/drive/drive_api_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/gdata_wapi_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/auth_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/auth_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/google_apis/request_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/request_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
7 years, 2 months ago (2013-10-10 05:32:40 UTC) #1
hashimoto
lgtm
7 years, 2 months ago (2013-10-10 05:38:01 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-10 09:06:28 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-10 11:01:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/26707004/1
7 years, 2 months ago (2013-10-11 00:29:22 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-11 03:26:44 UTC) #6
Message was sent while issue was closed.
Change committed as 228091

Powered by Google App Engine
This is Rietveld 408576698