Move CertVerifyProcMac unit-tests to their own file.

Move CertVerifyProcMac unit-tests to their own file.

Review-Url: https://codereview.chromium.org/2670643008
Cr-Commit-Position: refs/heads/master@{#448111}
Committed: https://chromium.googlesource.com/chromium/src/+/ce65aff6d1ecab7ec4e6c1bc34eadd0a983c3879

[eroman, 2017-02-02 21:11:49]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 21:12:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-02-02 21:13:15]

eroman@chromium.org changed reviewers:
+ rsleevi@chromium.org

[eroman, 2017-02-02 21:13:16]

wdyt?

[commit-bot: I haz the power, 2017-02-02 22:05:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 22:05:34]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2017-02-02 22:20:12]

Non-critical nit, but otherwise LGTM

https://codereview.chromium.org/2670643008/diff/1/net/test/cert_test_util.h
File net/test/cert_test_util.h (right):

https://codereview.chromium.org/2670643008/diff/1/net/test/cert_test_util.h#n...
net/test/cert_test_util.h:58: CertificateList* certs) {
A thought: It might be worth refactoring this a little to

template <typename ForwardIterator>
CertificateList LoadCertificateFiles(ForwardIterator first, ForwardIterator
last) {
  CertificateList result;
  for (; first != last; ++first) {
    SCOPED_TRACE(first);
   scoped_refptr<X509Certificate> cert = CreateCertificateChainFromFile(...);
   result.push_back(cert);
  }
  return certs;
}


Context for this is I generally get nervous about exposing the size_t N approach
in headers, because it's limited to a specific type - fixed arrays. The Iterator
approach still lets us use arrays (for std::begin(certs_files),
std::end(certs_files)), but allows a bit more flexibility when exposing
something as part of a public interface.

[eroman, 2017-02-02 23:25:37]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 23:26:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-02-02 23:27:17]

https://codereview.chromium.org/2670643008/diff/1/net/test/cert_test_util.h
File net/test/cert_test_util.h (right):

https://codereview.chromium.org/2670643008/diff/1/net/test/cert_test_util.h#n...
net/test/cert_test_util.h:58: CertificateList* certs) {
On 2017/02/02 22:20:12, Ryan Sleevi wrote:
> A thought: It might be worth refactoring this a little to
> 
> template <typename ForwardIterator>
> CertificateList LoadCertificateFiles(ForwardIterator first, ForwardIterator
> last) {
>   CertificateList result;
>   for (; first != last; ++first) {
>     SCOPED_TRACE(first);
>    scoped_refptr<X509Certificate> cert = CreateCertificateChainFromFile(...);
>    result.push_back(cert);
>   }
>   return certs;
> }
> 
> 
> Context for this is I generally get nervous about exposing the size_t N
approach
> in headers, because it's limited to a specific type - fixed arrays. The
Iterator
> approach still lets us use arrays (for std::begin(certs_files),
> std::end(certs_files)), but allows a bit more flexibility when exposing
> something as part of a public interface.

PTAL, I have removed the template parameter all-together.

[eroman, 2017-02-02 23:28:55]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 23:29:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Sleevi, 2017-02-02 23:30:07]

works for me - still LGTM

[commit-bot: I haz the power, 2017-02-02 23:52:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:52:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[eroman, 2017-02-03 22:22:49]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 22:23:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-02-03 23:13:32]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2017-02-03 23:13:35]

The CQ bit was checked by eroman@chromium.org

[eroman, 2017-02-03 23:13:36]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2670643008/#ps60001
(title: "Rebase + add missing include")

[commit-bot: I haz the power, 2017-02-03 23:13:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:05:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486163615816010,
"parent_rev": "0e05b275042fd6114f705d341a24f58c8e6cec4a", "commit_rev":
"ce65aff6d1ecab7ec4e6c1bc34eadd0a983c3879"}

[commit-bot: I haz the power, 2017-02-04 00:06:15]

Description was changed from

==========
Move CertVerifyProcMac unit-tests to their own file.
==========

to

==========
Move CertVerifyProcMac unit-tests to their own file.

Review-Url: https://codereview.chromium.org/2670643008
Cr-Commit-Position: refs/heads/master@{#448111}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce65aff6d1ecab7ec4e6c1bc34ea...
==========

[commit-bot: I haz the power, 2017-02-04 00:06:16]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ce65aff6d1ecab7ec4e6c1bc34ea...