Rename EDisplay values with k prefix.

Rename EDisplay values with k prefix.

Rename the values of the EDisplay enum with the k prefix to match
the style generated by make_computed_style_base.py, which is in line with
the Blink rename to match Chromium style. This is prework for generating
EDisplay.

BUG=684966
Review-Url: https://codereview.chromium.org/2670643004
Cr-Commit-Position: refs/heads/master@{#457356}
Committed: https://chromium.googlesource.com/chromium/src/+/be8002aa2f99d13a07546f12018d4add0b7e1be8

[shend, 2017-02-02 03:44:34]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-02-02 03:44:35]

Hi Bugs, another rename patch PTAL

[Bugs Nash, 2017-02-03 23:19:31]

lgtm

[shend, 2017-02-06 00:09:04]

Hi Sasha, PTAL

[shend, 2017-02-06 00:10:33]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-02-06 00:10:34]

Hi Sasha, PTAL

[haraken, 2017-02-06 00:16:09]

Chromium coding style is saying that enums should use ENUM_VALUE, not
kEnumValue.

"Though the Google C++ Style Guide now says to use kConstantNaming for enums,
Chromium was written using MACRO_STYLE naming. In enums that are actually
enumerations (i.e. have multiple values), continue to use this style for
consistency. Use kConstantNaming when using the “enum hack” to define a single
constant, as you would for a const int or the like."

https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md

[shend, 2017-02-06 01:49:08]

shend@chromium.org changed reviewers:
+ dcheng@chromium.org

[shend, 2017-02-06 01:49:09]

dcheng, PTAL haraken's comment about enum naming style. Should we be using
ENUM_NAME or kEnumName?

[dcheng, 2017-02-06 04:25:42]

On 2017/02/06 01:49:09, shend wrote:
> dcheng, PTAL haraken's comment about enum naming style. Should we be using
> ENUM_NAME or kEnumName?

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/iD1Tifsp64M has
some context: we've decided to explicitly differ from Chromium by using
kCamelCase. It's been awhile, so I don't recall the motivations behind this
decision (I've CCed danakj@ and esprehn@, who might recall the context)

From a personal perspective, I'm highly supportive of this change though (I've
had numerous issues in the past where MACRO_STYLE enumerator values collided
with macros in system headers).

[danakj, 2017-02-06 16:30:04]

On Sun, Feb 5, 2017 at 11:25 PM, <dcheng@chromium.org> wrote:

> On 2017/02/06 01:49:09, shend wrote:
> > dcheng, PTAL haraken's comment about enum naming style. Should we be
> using
> > ENUM_NAME or kEnumName?
>
> https://groups.google.com/a/chromium.org/forum/#!topic/
> blink-dev/iD1Tifsp64M has
> some context: we've decided to explicitly differ from Chromium by using
> kCamelCase. It's been awhile, so I don't recall the motivations behind this
> decision (I've CCed danakj@ and esprehn@, who might recall the context)
>

Because that's what Google does now. They used to allow either IIRC. We
discussed changing chromium's SHOUTY ones to match.

From a personal perspective, I'm highly supportive of this change though
> (I've
> had numerous issues in the past where MACRO_STYLE enumerator values
> collided
> with macros in system headers).
>
> https://codereview.chromium.org/2670643004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2017-02-06 16:35:43]

On Sun, Feb 5, 2017 at 11:25 PM, <dcheng@chromium.org> wrote:

> On 2017/02/06 01:49:09, shend wrote:
> > dcheng, PTAL haraken's comment about enum naming style. Should we be
> using
> > ENUM_NAME or kEnumName?
>
> https://groups.google.com/a/chromium.org/forum/#!topic/
> blink-dev/iD1Tifsp64M has
> some context: we've decided to explicitly differ from Chromium by using
> kCamelCase. It's been awhile, so I don't recall the motivations behind this
> decision (I've CCed danakj@ and esprehn@, who might recall the context)
>

Because that's what Google does now. They used to allow either IIRC. We
discussed changing chromium's SHOUTY ones to match.

From a personal perspective, I'm highly supportive of this change though
> (I've
> had numerous issues in the past where MACRO_STYLE enumerator values
> collided
> with macros in system headers).
>
> https://codereview.chromium.org/2670643004/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[shend, 2017-02-12 21:53:28]

shend@chromium.org changed reviewers:
+ meade@chromium.org
- sashab@chromium.org

[shend, 2017-02-12 21:53:30]

Cool, I'm guessing this is ok then.
Eddy, PTAL :)

[meade_UTC10, 2017-02-13 06:12:37]

lgtm

[shend, 2017-02-13 22:10:32]

shend@chromium.org changed reviewers:
+ aboxhall@chromium.org

[shend, 2017-02-13 22:10:33]

Hi Alice, PTAL for accessibility/

[aboxhall, 2017-03-15 22:48:14]

On 2017/02/13 22:10:33, shend wrote:
> Hi Alice, PTAL for accessibility/

LGTM for accessibility/

[shend, 2017-03-15 22:49:27]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 22:49:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2017-03-15 23:43:50]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2017-03-15 23:43:51]

lgtm

[commit-bot: I haz the power, 2017-03-16 00:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:14:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-03-16 00:34:17]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 00:35:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 02:57:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 02:57:09]

Dry run: This issue passed the CQ dry run.

[shend, 2017-03-16 02:58:04]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-16 02:58:05]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
bugsnash@chromium.org, esprehn@chromium.org, aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2670643004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-16 02:58:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 03:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 03:03:49]

Failed to apply patch for
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:832
  error: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp: patch
does not apply

Patch:       third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
index
88b049008c79992e177678e9ef68318f7bcc4529..c91d37746f0ed073ce8cbeabba61fed63da60279
100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
@@ -304,7 +304,7 @@ void
CSSAnimations::calculateAnimationUpdate(CSSAnimationUpdate& update,
   for (bool& flag : cancelRunningAnimationFlags)
     flag = true;
 
-  if (animationData && style.display() != EDisplay::None) {
+  if (animationData && style.display() != EDisplay::kNone) {
     const Vector<AtomicString>& nameList = animationData->nameList();
     for (size_t i = 0; i < nameList.size(); ++i) {
       AtomicString name = nameList[i];
@@ -832,7 +832,7 @@ void
CSSAnimations::calculateTransitionUpdate(CSSAnimationUpdate& update,
   std::bitset<numCSSProperties> listedProperties;
   bool anyTransitionHadTransitionAll = false;
   const LayoutObject* layoutObject = animatingElement->layoutObject();
-  if (!animationStyleRecalc && style.display() != EDisplay::None &&
+  if (!animationStyleRecalc && style.display() != EDisplay::kNone &&
       layoutObject && layoutObject->style() && transitionData) {
     TransitionUpdateState state = {
         update,         animatingElement,  *layoutObject->style(),

[shend, 2017-03-16 03:05:11]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-03-16 03:05:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 03:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 03:10:04]

Failed to apply patch for
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:832
  error: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp: patch
does not apply

Patch:       third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
index
88b049008c79992e177678e9ef68318f7bcc4529..c91d37746f0ed073ce8cbeabba61fed63da60279
100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
@@ -304,7 +304,7 @@ void
CSSAnimations::calculateAnimationUpdate(CSSAnimationUpdate& update,
   for (bool& flag : cancelRunningAnimationFlags)
     flag = true;
 
-  if (animationData && style.display() != EDisplay::None) {
+  if (animationData && style.display() != EDisplay::kNone) {
     const Vector<AtomicString>& nameList = animationData->nameList();
     for (size_t i = 0; i < nameList.size(); ++i) {
       AtomicString name = nameList[i];
@@ -832,7 +832,7 @@ void
CSSAnimations::calculateTransitionUpdate(CSSAnimationUpdate& update,
   std::bitset<numCSSProperties> listedProperties;
   bool anyTransitionHadTransitionAll = false;
   const LayoutObject* layoutObject = animatingElement->layoutObject();
-  if (!animationStyleRecalc && style.display() != EDisplay::None &&
+  if (!animationStyleRecalc && style.display() != EDisplay::kNone &&
       layoutObject && layoutObject->style() && transitionData) {
     TransitionUpdateState state = {
         update,         animatingElement,  *layoutObject->style(),

[shend, 2017-03-16 03:16:42]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-16 03:16:43]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
esprehn@chromium.org, bugsnash@chromium.org, aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2670643004/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-16 03:17:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 05:19:42]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489634202254940,
"parent_rev": "807219a299ce1f745a2520a105ff5b2875fc497a", "commit_rev":
"be8002aa2f99d13a07546f12018d4add0b7e1be8"}

[commit-bot: I haz the power, 2017-03-16 05:21:38]

Description was changed from

==========
Rename EDisplay values with k prefix.

Rename the values of the EDisplay enum with the k prefix to match
the style generated by make_computed_style_base.py, which is in line with
the Blink rename to match Chromium style. This is prework for generating
EDisplay.

BUG=684966
==========

to

==========
Rename EDisplay values with k prefix.

Rename the values of the EDisplay enum with the k prefix to match
the style generated by make_computed_style_base.py, which is in line with
the Blink rename to match Chromium style. This is prework for generating
EDisplay.

BUG=684966

Review-Url: https://codereview.chromium.org/2670643004
Cr-Commit-Position: refs/heads/master@{#457356}
Committed:
https://chromium.googlesource.com/chromium/src/+/be8002aa2f99d13a07546f12018d...
==========

[commit-bot: I haz the power, 2017-03-16 05:21:40]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/be8002aa2f99d13a07546f12018d...