Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2670643003: Convert ChannelMerger Audit tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ChannelMerger Audit tests to testharness These tests were converted to use testharness via the script for f in `grep -l Audit *.html` do # Replace js-test with testharness and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove old js-test methods that no longer exist. sed -i '/^[ ]*\(description(.*)\|finishJSTest()\);[ ]*$/d' $f # Remove jsTestIsAsync stuff sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f # Remove expected results file. base=`basename $f .html` git rm $base-expected.txt done However, audiochannelmerger-cycle.html needed some hand-modifications because of the use of testPassed/testFailed. Also, fixed minor issue in the code where there was a loop that ran the test twice unnecessarily. BUG=687756 TEST=audiochannelmerger-basic.html, audiochannelmerger-cycle.html, audiochannelmerger-disconnect.html, audiochannelmerger-input-non-default.html, audiochannelmerger-input.html Review-Url: https://codereview.chromium.org/2670643003 Cr-Commit-Position: refs/heads/master@{#447828} Committed: https://chromium.googlesource.com/chromium/src/+/bb595a5e5abad3b90dd05419c3c10f9c47d3976d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -139 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-basic.html View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-basic-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-cycle.html View 3 chunks +12 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-cycle-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-disconnect.html View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-disconnect-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-input.html View 3 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-input-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-input-non-default.html View 3 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/ChannelMerger/audiochannelmerger-input-non-default-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-02 16:17:14 UTC) #2
hongchan
lgtm
3 years, 10 months ago (2017-02-02 19:43:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670643003/1
3 years, 10 months ago (2017-02-02 19:50:31 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 20:07:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb595a5e5abad3b90dd05419c3c1...

Powered by Google App Engine
This is Rietveld 408576698