Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: Source/core/rendering/RenderFullScreen.cpp

Issue 267053002: ASSERT on renderer lifecycle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderListItem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderFullScreen.cpp
diff --git a/Source/core/rendering/RenderFullScreen.cpp b/Source/core/rendering/RenderFullScreen.cpp
index bca1d5b9d1cb4bf92d9e00c77339391b43297c36..2abefb8fe97f9cd3faeb73208d69ba7a16d0979f 100644
--- a/Source/core/rendering/RenderFullScreen.cpp
+++ b/Source/core/rendering/RenderFullScreen.cpp
@@ -110,6 +110,10 @@ static PassRefPtr<RenderStyle> createFullScreenStyle()
RenderObject* RenderFullScreen::wrapRenderer(RenderObject* object, RenderObject* parent, Document* document)
{
+ // FIXME: We should not modify the structure of the render tree during
+ // layout. crbug.com/370459
+ DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
+
RenderFullScreen* fullscreenRenderer = RenderFullScreen::createAnonymous(document);
fullscreenRenderer->setStyle(createFullScreenStyle());
if (parent && !parent->isChildAllowed(fullscreenRenderer, fullscreenRenderer->style())) {
@@ -146,6 +150,10 @@ RenderObject* RenderFullScreen::wrapRenderer(RenderObject* object, RenderObject*
void RenderFullScreen::unwrapRenderer()
{
+ // FIXME: We should not modify the structure of the render tree during
+ // layout. crbug.com/370459
+ DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
+
if (parent()) {
RenderObject* child;
while ((child = firstChild())) {
« no previous file with comments | « Source/core/rendering/RenderBlock.cpp ('k') | Source/core/rendering/RenderListItem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698