Source/core/rendering/RenderBlock.cpp - Issue 267053002: ASSERT on renderer lifecycle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 267053002: ASSERT on renderer lifecycle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index b3823e6393dcb33b6353b37f6a9901acdb98a300..897fc694d33c22a9733d0e89e7b911550daf3da9 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -4019,8 +4019,12 @@ void RenderBlock::createFirstLetterRenderer(RenderObject* firstLetterBlock, Rend

else

firstLetter = RenderBlockFlow::createAnonymous(&document());

firstLetter->setStyle(pseudoStyle);

- firstLetterContainer->addChild(firstLetter, currentChild);

+ // FIXME: The first letter code should not modify the render tree during

+ // layout. crbug.com/370458

+ DeprecatedDisableModifyRenderTreeStructureAsserts disabler;

+ firstLetterContainer->addChild(firstLetter, currentChild);

RenderText* textObj = toRenderText(currentChild);

// The original string is going to be either a generated content string or a DOM node's

« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/rendering/RenderFullScreen.cpp » ('j') | no next file with comments »