Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: Source/core/dom/Node.cpp

Issue 267053002: ASSERT on renderer lifecycle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Node.cpp
diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
index 338aa5734b2ed6ec461f18cb4d2f1241a99d82d4..24d7fcf02e502e9249a73e4e918d02c4fe7bd4cf 100644
--- a/Source/core/dom/Node.cpp
+++ b/Source/core/dom/Node.cpp
@@ -995,6 +995,10 @@ bool Node::inDetach() const
void Node::detach(const AttachContext& context)
{
+ // FIXME: We should not modify the structure of the render tree during
+ // layout. crbug.com/370463
esprehn 2014/05/08 05:41:25 This doesn't need a fix me, it's correct to modify
dsinclair 2014/05/08 19:32:11 Done.
+ DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
+
#ifndef NDEBUG
ASSERT(!detachingNode);
detachingNode = this;

Powered by Google App Engine
This is Rietveld 408576698