ASSERT on renderer lifecycle

Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 977 matching lines @@
 static Node* detachingNode;
 
 bool Node::inDetach() const
 {
     return detachingNode == this;
 }
 #endif
 
 void Node::detach(const AttachContext& context)
 {
+    // FIXME: We should not modify the structure of the render tree during
+    // layout. crbug.com/370463

[esprehn, 2014/05/08 05:41:25]

This doesn't need a fix me, it's correct to modify the render tree inside
::detach.

[dsinclair, 2014/05/08 19:32:11]

Done.

+    DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
+
 #ifndef NDEBUG
     ASSERT(!detachingNode);
     detachingNode = this;
 #endif
 
     if (renderer())
         renderer()->destroyAndCleanupAnonymousWrappers();
     setRenderer(0);
 
     // Do not remove the element's hovered and active status
@@ skipping 1576 matching lines @@
         node->showTreeForThis();
 }
 
 void showNodePath(const WebCore::Node* node)
 {
     if (node)
         node->showNodePathForThis();
 }
 
 #endif