Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2670513002: Merged: [turbofan] escape analysis reducer no longer confused by TypeGuards it introduced itself (Closed)

Created:
3 years, 10 months ago by Tobias Tebbi
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [turbofan] escape analysis reducer no longer confused by TypeGuards it introduced itself Revision: 8b6fa9d519fb4af611d91cc2c896532147ea0bda BUG=chromium:682570 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2670513002 Cr-Commit-Position: refs/branch-heads/5.7@{#80} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/b1ffba35975b41a0db0da26fc469c4759499c405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M src/compiler/escape-analysis-reducer.cc View 6 chunks +15 lines, -6 lines 0 comments Download
A test/mjsunit/compiler/escape-analysis-12.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tobias Tebbi
3 years, 10 months ago (2017-02-01 10:03:39 UTC) #1
Tobias Tebbi
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-01 10:03:41 UTC) #2
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-02-01 10:24:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670513002/1
3 years, 10 months ago (2017-02-01 11:34:06 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 11:34:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b1ffba35975b41a0db0da26fc469c475949...

Powered by Google App Engine
This is Rietveld 408576698