[arc notifications] Inspect pinned flag directly for IsPinned().

[arc notifications] Inspect pinned flag directly for IsPinned().

When an ARC notification comes, the 'discard notifications' button in
the notifications tray is greyed out until you hover over the
notification. ArcCustomNotificationView::ContentViewDelegate would
check whether ArcCustomNotificationView::floating_close_button_ existed
to determine if the notification is pinned or not. Pinned notifications
cannot be closed. The floating close button is created if the notification
is not pinned. However, it is created after the check inside
ContentViewDelegate. Instead, inspect the pinned state directly from
ArcCustomNotificationItem.

BUG=685467
Review-Url: https://codereview.chromium.org/2670493002
Cr-Commit-Position: refs/heads/master@{#447698}
Committed: https://chromium.googlesource.com/chromium/src/+/581285b278ce65ddf216a03295333bd396239c03

[Eliot Courtney, 2017-02-01 08:08:33]

The CQ bit was checked by edcourtney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 08:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eliot Courtney, 2017-02-01 08:09:32]

edcourtney@chromium.org changed reviewers:
+ yhanada@chromium.org, yoshiki@chromium.org

[commit-bot: I haz the power, 2017-02-01 08:49:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 08:49:19]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-02-01 09:40:17]

lgtm

[yoshiki, 2017-02-02 03:22:02]

lgtm

[Eliot Courtney, 2017-02-02 03:33:23]

The CQ bit was checked by edcourtney@chromium.org

[commit-bot: I haz the power, 2017-02-02 03:33:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 05:07:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486006403303890, "parent_rev":
"8d24b2d5f9d6e67d53f2aa8e532430f2dd096d59", "commit_rev":
"581285b278ce65ddf216a03295333bd396239c03"}

[commit-bot: I haz the power, 2017-02-02 05:08:30]

Description was changed from

==========
[arc notifications] Inspect pinned flag directly for IsPinned().

When an ARC notification comes, the 'discard notifications' button in
the notifications tray is greyed out until you hover over the
notification. ArcCustomNotificationView::ContentViewDelegate would
check whether ArcCustomNotificationView::floating_close_button_ existed
to determine if the notification is pinned or not. Pinned notifications
cannot be closed. The floating close button is created if the notification
is not pinned. However, it is created after the check inside
ContentViewDelegate. Instead, inspect the pinned state directly from
ArcCustomNotificationItem.

BUG=685467
==========

to

==========
[arc notifications] Inspect pinned flag directly for IsPinned().

When an ARC notification comes, the 'discard notifications' button in
the notifications tray is greyed out until you hover over the
notification. ArcCustomNotificationView::ContentViewDelegate would
check whether ArcCustomNotificationView::floating_close_button_ existed
to determine if the notification is pinned or not. Pinned notifications
cannot be closed. The floating close button is created if the notification
is not pinned. However, it is created after the check inside
ContentViewDelegate. Instead, inspect the pinned state directly from
ArcCustomNotificationItem.

BUG=685467

Review-Url: https://codereview.chromium.org/2670493002
Cr-Commit-Position: refs/heads/master@{#447698}
Committed:
https://chromium.googlesource.com/chromium/src/+/581285b278ce65ddf216a0329533...
==========

[commit-bot: I haz the power, 2017-02-02 05:08:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/581285b278ce65ddf216a0329533...