Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2670473003: [css-grid] Import W3C Test Suite (Closed)

Created:
3 years, 10 months ago by Manuel Rego
Modified:
3 years, 10 months ago
Reviewers:
tkent, qyearsley, foolip
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, jfernandez, svillar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Import W3C Test Suite This patch imports the CSS Grid Layout test suite from csswg-test repository. Currently we're passing most of the but: * grid-layout-properties.html: An old known bug (crbug.com/511177). * grid-support-grid-template-areas-001.xht & grid-inline-support-grid-template-areas-001.xht: Because of an issue with testharness.js (crbug.com/687492). Additionally I'm skipping the tests related to "Implied Minimum Size of Grid Items" (https://drafts.csswg.org/css-grid/#min-size-auto), because the test suite needs to be updated after the CSS WG resolves the following issue: https://github.com/w3c/csswg-drafts/issues/283 See crbug.com/666940 for more details. BUG=687494 Review-Url: https://codereview.chromium.org/2670473003 Cr-Commit-Position: refs/heads/master@{#447562} Committed: https://chromium.googlesource.com/chromium/src/+/91d2f36bd1fd37e7941b68fe85a9e674c4c84882

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment about skipped tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9181 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +17 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/README.md View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/fr-unit.html View 1 chunk +105 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/fr-unit-expected.html View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage.html View 1 chunk +102 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/fr-unit-with-percentage-expected.html View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-inline-support-flexible-lengths-001.xht View 1 chunk +105 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-areas-001.xht View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-inline-support-grid-template-columns-rows-001.xht View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-inline-support-named-grid-lines-001.xht View 1 chunk +123 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-inline-support-repeat-001.xht View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-inline-template-columns-rows-resolved-values-001.xht View 1 chunk +107 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks.html View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-layout-auto-tracks-expected.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-layout-basic.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-layout-basic-expected.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation.html View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-layout-repeat-notation-expected.html View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-support-flexible-lengths-001.xht View 1 chunk +105 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-support-grid-template-areas-001.xht View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-support-grid-template-columns-rows-001.xht View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-support-named-grid-lines-001.xht View 1 chunk +123 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-support-repeat-001.xht View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/grid-template-columns-rows-resolved-values-001.xht View 1 chunk +107 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-definition/support/testing-utils.js View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-items-001.xht View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-items-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-items-002.xht View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-items-002-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-items-003.xht View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-items-003-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-items-inline-blocks-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001.xht View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-001-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002.xht View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-002-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003.xht View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-003-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004.xht View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-004-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005.xht View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-auto-placement-005-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-002-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003.xht View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-003-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004.xht View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-004-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005.xht View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-order-property-painting-005-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001.xht View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002.xht View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-002-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-003-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-004-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-005-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-001-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002.xht View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-002-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003.xht View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-003-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-004-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-005-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006.xht View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-inline-z-axis-ordering-overlapped-items-006-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-item-containing-block-001.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-item-containing-block-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-item-containing-block-002.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-item-containing-block-002-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-item-containing-block-003.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-item-containing-block-003-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-item-containing-block-004.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-item-containing-block-004-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-items-001.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-items-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-items-002.xht View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-items-002-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-items-003.xht View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-items-003-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-items-inline-blocks-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid.html View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-layout-grid-in-grid-expected.html View 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-layout-z-order-a.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-layout-z-order-a-expected.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-layout-z-order-b.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-layout-z-order-b-expected.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001.xht View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002.xht View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-002-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003.xht View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-003-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004.xht View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-004-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005.xht View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-005-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-006-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-007-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-008-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-minimum-size-grid-items-009-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001.xht View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-001-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002.xht View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-002-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003.xht View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-003-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004.xht View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-004-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005.xht View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-auto-placement-005-expected.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-001.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-002.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-002-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-003.xht View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-003-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-004.xht View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-004-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-005.xht View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-order-property-painting-005-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001.xht View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002.xht View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-002-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-003-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-004-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005.xht View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-005-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-001-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002.xht View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-002-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003.xht View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-003-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-004-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-005-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006.xht View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/grid-z-axis-ordering-overlapped-items-006-expected.xht View 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/support/100x100-green.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/support/100x50-green.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/support/200x200-green.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-items/support/50x100-green.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-layout-properties.html View 1 chunk +233 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/display-grid.html View 1 chunk +107 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/display-grid-expected.html View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/display-inline-grid.html View 1 chunk +111 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/display-inline-grid-expected.html View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-computed-value-display-floated-items-001.xht View 1 chunk +87 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-display-grid-001.xht View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-display-grid-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001.xht View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-display-inline-grid-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-letter-001.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-letter-001-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-letter-002.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-letter-002-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-letter-003.xht View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-letter-003-expected.xht View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-line-001.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-line-001-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-line-002.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-line-002-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-line-003.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-first-line-003-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-float-001.xht View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-float-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001.xht View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-floats-no-intrude-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-letter-001-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-letter-002-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003.xht View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-letter-003-expected.xht View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-line-001.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-line-001-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-line-002.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-line-002-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-line-003.xht View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-first-line-003-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-float-001.xht View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-float-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001.xht View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-floats-no-intrude-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001.xht View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-margins-no-collapse-001-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-multicol-001.xht View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-multicol-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001.xht View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-inline-vertical-align-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001.xht View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-margins-no-collapse-001-expected.xht View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-multicol-001.xht View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-multicol-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-support-display-001.xht View 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-vertical-align-001.xht View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/grid-model/grid-vertical-align-001-expected.xht View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/implicit-grids/grid-support-grid-auto-columns-rows-001-expected.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/layout-algorithm/grid-layout-free-space-unit-expected.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/placement/grid-layout-grid-span.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/placement/grid-layout-grid-span-expected.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/placement/grid-layout-lines.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/placement/grid-layout-lines-expected.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/placement/grid-layout-lines-shorthands.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/placement/grid-layout-lines-shorthands-expected.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/placement/grid-layout-placement-shorthands.html View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/csswg-test/css-grid-1/placement/grid-layout-placement-shorthands-expected.html View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Manuel Rego
3 years, 10 months ago (2017-02-01 10:28:30 UTC) #2
foolip
lgtm % something in the description for skipped tests. https://codereview.chromium.org/2670473003/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2670473003/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode2074 third_party/WebKit/LayoutTests/TestExpectations:2074: ...
3 years, 10 months ago (2017-02-01 16:59:09 UTC) #3
Manuel Rego
On 2017/02/01 16:59:09, foolip wrote: > lgtm % something in the description for skipped tests. ...
3 years, 10 months ago (2017-02-01 17:02:22 UTC) #4
qyearsley
lgtm as well, with a comment about https://github.com/w3c/csswg-drafts/issues/283 and crbug.com/666940 above the skips
3 years, 10 months ago (2017-02-01 17:03:11 UTC) #5
Manuel Rego
Ok, thanks for the reviews. Added a comment on TestExpectations with a TODO as I'll ...
3 years, 10 months ago (2017-02-01 17:17:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670473003/20001
3 years, 10 months ago (2017-02-01 17:17:33 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 18:54:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/91d2f36bd1fd37e7941b68fe85a9...

Powered by Google App Engine
This is Rietveld 408576698