Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2670383004: Merged: [crankshaft] Fix string addition to check for max length of cons string. (Closed)

Created:
3 years, 10 months ago by Jarin
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [crankshaft] Fix string addition to check for max length of cons string. Revision: dd310b434181902a8e8a93890dd634a2e8cfc825 BUG=chromium:678917 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2670383004 . Cr-Commit-Position: refs/branch-heads/5.7@{#88} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/01199dc9213435603a051051d881701f841b79a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-678917.js View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
3 years, 10 months ago (2017-02-04 21:52:34 UTC) #1
Jarin
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-04 21:52:35 UTC) #2
Jarin
3 years, 10 months ago (2017-02-04 21:53:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
01199dc9213435603a051051d881701f841b79a8.

Powered by Google App Engine
This is Rietveld 408576698