Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2670363002:
[system-health] Re-enable memory_mobile.reference on Nexus 5X. (Closed)
Description[system-health] Re-enable memory_mobile.reference on Nexus 5X.
Reference versions were incremented in https://crrev.com/2582303003 and
problem seems not being happening anymore.
BUG=612144
Review-Url: https://codereview.chromium.org/2670363002
Cr-Commit-Position: refs/heads/master@{#448233}
Committed: https://chromium.googlesource.com/chromium/src/+/3084cf9e91e970838660a8ea381f5771cf8d54dd
Patch Set 1 #
Total comments: 2
Patch Set 2 : decorators #Messages
Total messages: 18 (11 generated)
The CQ bit was checked by kraynov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
kraynov@chromium.org changed reviewers: + hjd@chromium.org, nednguyen@google.com
PTAL
lgtm
https://codereview.chromium.org/2670363002/diff/1/tools/perf/benchmarks/syste... File tools/perf/benchmarks/system_health.py (right): https://codereview.chromium.org/2670363002/diff/1/tools/perf/benchmarks/syste... tools/perf/benchmarks/system_health.py:134: def ShouldDisable(cls, possible_browser): Can you update this benchmark class to just use "@decorators.Enable('android') instead?
https://codereview.chromium.org/2670363002/diff/1/tools/perf/benchmarks/syste... File tools/perf/benchmarks/system_health.py (right): https://codereview.chromium.org/2670363002/diff/1/tools/perf/benchmarks/syste... tools/perf/benchmarks/system_health.py:134: def ShouldDisable(cls, possible_browser): On 2017/02/03 16:51:01, nednguyen wrote: > Can you update this benchmark class to just use mailto:"@decorators.Enable( > instead? Done.
On 2017/02/03 17:03:12, kraynov wrote: > https://codereview.chromium.org/2670363002/diff/1/tools/perf/benchmarks/syste... > File tools/perf/benchmarks/system_health.py (right): > > https://codereview.chromium.org/2670363002/diff/1/tools/perf/benchmarks/syste... > tools/perf/benchmarks/system_health.py:134: def ShouldDisable(cls, > possible_browser): > On 2017/02/03 16:51:01, nednguyen wrote: > > Can you update this benchmark class to just use mailto:"@decorators.Enable( > > instead? > > Done. lgtm
The CQ bit was checked by kraynov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kraynov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2670363002/#ps20001 (title: "decorators")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486376923891210,
"parent_rev": "e43dc3eb142ce7a0cfb53da544dc373ef9ac6888", "commit_rev":
"3084cf9e91e970838660a8ea381f5771cf8d54dd"}
Message was sent while issue was closed.
Description was changed from ========== [system-health] Re-enable memory_mobile.reference on Nexus 5X. Reference versions were incremented in https://crrev.com/2582303003 and problem seems not being happening anymore. BUG=612144 ========== to ========== [system-health] Re-enable memory_mobile.reference on Nexus 5X. Reference versions were incremented in https://crrev.com/2582303003 and problem seems not being happening anymore. BUG=612144 Review-Url: https://codereview.chromium.org/2670363002 Cr-Commit-Position: refs/heads/master@{#448233} Committed: https://chromium.googlesource.com/chromium/src/+/3084cf9e91e970838660a8ea381f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3084cf9e91e970838660a8ea381f... |
