Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2670303003: Make service tests more resilient to isolate load timing (Closed)

Created:
3 years, 10 months ago by jensj
Modified:
3 years, 10 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Naming change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M runtime/observatory/tests/service/test_helper.dart View 1 2 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
jensj
While this might just be a problem when running the service tests via kernel I ...
3 years, 10 months ago (2017-02-03 14:53:40 UTC) #2
Cutch
LGTM with a naming nit https://codereview.chromium.org/2670303003/diff/1/runtime/observatory/tests/service/test_helper.dart File runtime/observatory/tests/service/test_helper.dart (right): https://codereview.chromium.org/2670303003/diff/1/runtime/observatory/tests/service/test_helper.dart#newcode347 runtime/observatory/tests/service/test_helper.dart:347: Future<Isolate> getIsolate(WebSocketVM vm) async ...
3 years, 10 months ago (2017-02-08 15:45:59 UTC) #4
jensj
3 years, 10 months ago (2017-02-09 09:02:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
65e5de9a4291dc496dae1b7ff279f1891997d84d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698