Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2670223002: Add cr_scrollable_behavior tests (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cr_scrollable_behavior tests BUG=669248 Review-Url: https://codereview.chromium.org/2670223002 Cr-Commit-Position: refs/heads/master@{#448150} Committed: https://chromium.googlesource.com/chromium/src/+/e3cd1477cda2dc5affdd1b3711e507c6c2025fbe

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : Rebase + @constructor comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -0 lines) Patch
M chrome/test/data/webui/cr_elements/cr_elements_browsertest.js View 1 2 3 6 chunks +42 lines, -0 lines 0 comments Download
A chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js View 1 2 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
stevenjb
3 years, 10 months ago (2017-02-02 20:16:50 UTC) #2
Dan Beam
awesome. lgtm! https://codereview.chromium.org/2670223002/diff/40001/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js File chrome/test/data/webui/cr_elements/cr_elements_browsertest.js (right): https://codereview.chromium.org/2670223002/diff/40001/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js#newcode135 chrome/test/data/webui/cr_elements/cr_elements_browsertest.js:135: nit: @constructor and associated copy pasta
3 years, 10 months ago (2017-02-03 22:29:00 UTC) #3
stevenjb
https://codereview.chromium.org/2670223002/diff/40001/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js File chrome/test/data/webui/cr_elements/cr_elements_browsertest.js (right): https://codereview.chromium.org/2670223002/diff/40001/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js#newcode135 chrome/test/data/webui/cr_elements/cr_elements_browsertest.js:135: On 2017/02/03 22:29:00, Dan Beam (slow) wrote: > nit: ...
3 years, 10 months ago (2017-02-04 00:37:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670223002/60001
3 years, 10 months ago (2017-02-04 00:38:17 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 02:34:48 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e3cd1477cda2dc5affdd1b3711e5...

Powered by Google App Engine
This is Rietveld 408576698