Pass BS/Return Key Events to EditBox in Custom Notification

Pass BS/Return Key Events to EditBox in Custom Notification

Previously, BS and return key events were consumed by the message center and the custom contents couldn't receive them.

This patch adds a check if the current input mode is none or not. If the type is not none (it means the focus is on edit box), we don't handle  BS/Return key events and pass them to the custom notification content. 

BUG=679664
TEST=manually (BS and Return keys work on custom notification)

Review-Url: https://codereview.chromium.org/2670213002
Cr-Commit-Position: refs/heads/master@{#447954}
Committed: https://chromium.googlesource.com/chromium/src/+/8f2d158964de19b39244ecf483be0b156cb38224

[yoshiki, 2017-02-02 19:34:41]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 19:35:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-02-02 19:41:48]

Description was changed from

==========
wip

.


.


.

BUG=
==========

to

==========
Pass BS/Return Key Events to Editbox in Custom Notification

Previously, BS and return key events were consumed by the message center and the
custom contents couldn't receive them.

This patch adds a check if the current input mode is none or not. If the type is
not none (it means the focus is on edit box), we don't handle  BS/Return key
events and pass them to the custom notification content. 

BUG=679664
TEST=manually (BS and Return keys work on custom notification)
==========

[yoshiki, 2017-02-02 19:41:48]

yoshiki@chromium.org changed reviewers:
+ dewittj@chromium.org

[yoshiki, 2017-02-02 19:43:40]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 19:43:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-02-02 19:44:28]

Justin, PTAL. Thanks.

[yoshiki, 2017-02-02 19:45:05]

Description was changed from

==========
Pass BS/Return Key Events to Editbox in Custom Notification

Previously, BS and return key events were consumed by the message center and the
custom contents couldn't receive them.

This patch adds a check if the current input mode is none or not. If the type is
not none (it means the focus is on edit box), we don't handle  BS/Return key
events and pass them to the custom notification content. 

BUG=679664
TEST=manually (BS and Return keys work on custom notification)
==========

to

==========
Pass BS/Return Key Events to EditBox in Custom Notification

Previously, BS and return key events were consumed by the message center and the
custom contents couldn't receive them.

This patch adds a check if the current input mode is none or not. If the type is
not none (it means the focus is on edit box), we don't handle  BS/Return key
events and pass them to the custom notification content. 

BUG=679664
TEST=manually (BS and Return keys work on custom notification)
==========

[commit-bot: I haz the power, 2017-02-02 20:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 20:38:55]

Dry run: This issue passed the CQ dry run.

[dewittj, 2017-02-02 21:40:11]

Any chance we can get an automated test?

this lgtm as is though.

[yoshiki, 2017-02-03 05:27:48]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 05:28:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 05:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 05:42:20]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2017-02-03 05:50:16]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 05:50:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 06:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 06:47:43]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2017-02-03 06:48:36]

Patchset #3 (id:40001) has been deleted

[yoshiki, 2017-02-03 06:48:42]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2017-02-03 06:48:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2670213002/#ps60001
(title: "Added tests")

[commit-bot: I haz the power, 2017-02-03 06:48:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2017-02-03 06:49:00]

On 2017/02/02 21:40:11, dewittj wrote:
> Any chance we can get an automated test?
> 
> this lgtm as is though.

Thanks! I added tests.

[commit-bot: I haz the power, 2017-02-03 07:05:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486104522947470,
"parent_rev": "ee59954e558b897d48fb154918d3383fc574f024", "commit_rev":
"8f2d158964de19b39244ecf483be0b156cb38224"}

[commit-bot: I haz the power, 2017-02-03 07:06:07]

Description was changed from

==========
Pass BS/Return Key Events to EditBox in Custom Notification

Previously, BS and return key events were consumed by the message center and the
custom contents couldn't receive them.

This patch adds a check if the current input mode is none or not. If the type is
not none (it means the focus is on edit box), we don't handle  BS/Return key
events and pass them to the custom notification content. 

BUG=679664
TEST=manually (BS and Return keys work on custom notification)
==========

to

==========
Pass BS/Return Key Events to EditBox in Custom Notification

Previously, BS and return key events were consumed by the message center and the
custom contents couldn't receive them.

This patch adds a check if the current input mode is none or not. If the type is
not none (it means the focus is on edit box), we don't handle  BS/Return key
events and pass them to the custom notification content. 

BUG=679664
TEST=manually (BS and Return keys work on custom notification)

Review-Url: https://codereview.chromium.org/2670213002
Cr-Commit-Position: refs/heads/master@{#447954}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f2d158964de19b39244ecf483be...
==========

[commit-bot: I haz the power, 2017-02-03 07:06:08]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8f2d158964de19b39244ecf483be...