Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2670183004: [turbofan] Fix machine signature allocation bug. (Closed)

Created:
3 years, 10 months ago by Jarin
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix machine signature allocation bug. Review-Url: https://codereview.chromium.org/2670183004 Cr-Commit-Position: refs/heads/master@{#42921} Committed: https://chromium.googlesource.com/v8/v8/+/b48de9776ef063b983e664cd67f846c570952ff0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/linkage.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Jarin
Could you take a look, please?
3 years, 10 months ago (2017-02-03 10:59:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670183004/1
3 years, 10 months ago (2017-02-03 11:48:32 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-03 11:48:33 UTC) #7
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-02-03 11:48:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670183004/1
3 years, 10 months ago (2017-02-03 11:49:32 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 12:13:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b48de9776ef063b983e664cd67f846c5709...

Powered by Google App Engine
This is Rietveld 408576698