Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2670163002: Make wide logs an option in task-page (Closed)

Created:
3 years, 10 months ago by kjlubick
Modified:
3 years, 10 months ago
Reviewers:
KevinL, stephana, hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Make wide logs an option in task-page In narrow mode, the logs are wrapped. In wide mode, they get a scrollbar if they are too wide to fit on the screen. This also fixes a bug where multiple spaces in a row were being collapsed (whitespace: pre-line vs prewrap) which threw off alignment in logs. BUG=672613 Review-Url: https://codereview.chromium.org/2670163002 Committed: https://github.com/luci/luci-py/commit/cdda2304436ad1731189aaa50ef55cd0773d0da6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -13 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/swarming/ui/res/imp/botpage/bot-page.html View 1 chunk +0 lines, -8 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/single-page-style.html View 1 chunk +4 lines, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 1 8 chunks +47 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
kjlubick
See it live at https://2602-dacb7a1-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/task?id=34183abba73ef310&refresh=10&show_raw=1 https://screencast.googleplex.com/cast/NTE1NTIyNTUyMjQwNTM3Nnw0MjY3NmRjNC00MQ
3 years, 10 months ago (2017-02-02 15:28:44 UTC) #3
hinoka
demo link doesn't work (version overwritten?), but screencast lg lgtm, but I'm not an owner ...
3 years, 10 months ago (2017-02-02 23:23:29 UTC) #4
stephana
LGTM modulo a nit https://codereview.chromium.org/2670163002/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html File appengine/swarming/ui/res/imp/taskpage/task-page.html (right): https://codereview.chromium.org/2670163002/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html#newcode526 appengine/swarming/ui/res/imp/taskpage/task-page.html:526: <div class$="[[_classRight(_wide_logs)]]" hidden$="[[_not(_task_exists)]]"> Nit: the ...
3 years, 10 months ago (2017-02-03 14:57:09 UTC) #5
KevinL
lgtm
3 years, 10 months ago (2017-02-03 16:25:20 UTC) #7
kjlubick
https://codereview.chromium.org/2670163002/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html File appengine/swarming/ui/res/imp/taskpage/task-page.html (right): https://codereview.chromium.org/2670163002/diff/1/appengine/swarming/ui/res/imp/taskpage/task-page.html#newcode526 appengine/swarming/ui/res/imp/taskpage/task-page.html:526: <div class$="[[_classRight(_wide_logs)]]" hidden$="[[_not(_task_exists)]]"> On 2017/02/03 at 14:57:09, stephana wrote: ...
3 years, 10 months ago (2017-02-03 16:25:25 UTC) #9
kjlubick
3 years, 10 months ago (2017-02-03 16:25:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670163002/20001
3 years, 10 months ago (2017-02-03 16:25:57 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 16:29:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/cdda2304436ad1731189aaa50ef55cd0773d0da6

Powered by Google App Engine
This is Rietveld 408576698