Make wide logs an option in task-page

Make wide logs an option in task-page

In narrow mode, the logs are wrapped.  In wide mode, they get a scrollbar if they are too wide to fit on the screen.

This also fixes a bug where multiple spaces in a row were being collapsed
(whitespace: pre-line vs prewrap) which threw off alignment in logs.

BUG=672613
Review-Url: https://codereview.chromium.org/2670163002
Committed: https://github.com/luci/luci-py/commit/cdda2304436ad1731189aaa50ef55cd0773d0da6

[kjlubick, 2017-02-02 15:27:55]

Description was changed from

==========
Make wide logs an option in task-page

This also fixes a bug where multiple spaces in a row were being collapsed
(whitespace: pre-line vs prewrap) which threw off alignment in logs.

BUG=672613
==========

to

==========
Make wide logs an option in task-page

In narrow mode, the logs are wrapped.  In wide mode, they get a scrollbar if
they are too wide to fit on the screen.

This also fixes a bug where multiple spaces in a row were being collapsed
(whitespace: pre-line vs prewrap) which threw off alignment in logs.

BUG=672613
==========

[kjlubick, 2017-02-02 15:28:43]

kjlubick@google.com changed reviewers:
+ hinoka@chromium.org, stephana@google.com

[kjlubick, 2017-02-02 15:28:44]

See it live at
https://2602-dacb7a1-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/task...

https://screencast.googleplex.com/cast/NTE1NTIyNTUyMjQwNTM3Nnw0MjY3NmRjNC00MQ

[hinoka, 2017-02-02 23:23:29]

demo link doesn't work (version overwritten?), but screencast lg

lgtm, but I'm not an owner tho

[stephana, 2017-02-03 14:57:09]

LGTM modulo a nit

https://codereview.chromium.org/2670163002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/taskpage/task-page.html (right):

https://codereview.chromium.org/2670163002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/taskpage/task-page.html:526: <div
class$="[[_classRight(_wide_logs)]]" hidden$="[[_not(_task_exists)]]">
Nit: the constant classes should be in the markup rather than the JS. 
i.e. 

... class$="flex right [[_classRight(_wide_logs)]]" ...

same for _classStdout.

[KevinL, 2017-02-03 16:25:19]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2017-02-03 16:25:20]

lgtm

[kjlubick, 2017-02-03 16:25:25]

kjlubick@google.com changed reviewers:
- kjlubick@chromium.org

[kjlubick, 2017-02-03 16:25:25]

https://codereview.chromium.org/2670163002/diff/1/appengine/swarming/ui/res/i...
File appengine/swarming/ui/res/imp/taskpage/task-page.html (right):

https://codereview.chromium.org/2670163002/diff/1/appengine/swarming/ui/res/i...
appengine/swarming/ui/res/imp/taskpage/task-page.html:526: <div
class$="[[_classRight(_wide_logs)]]" hidden$="[[_not(_task_exists)]]">
On 2017/02/03 at 14:57:09, stephana wrote:
> Nit: the constant classes should be in the markup rather than the JS. 
> i.e. 
> 
> ... class$="flex right [[_classRight(_wide_logs)]]" ...
> 
> same for _classStdout.

Done.

[kjlubick, 2017-02-03 16:25:46]

kjlubick@google.com changed reviewers:
+ kjlubick@chromium.org

[kjlubick, 2017-02-03 16:25:46]

The CQ bit was checked by kjlubick@google.com

[kjlubick, 2017-02-03 16:25:47]

The patchset sent to the CQ was uploaded after l-g-t-m from stephana@google.com,
hinoka@chromium.org
Link to the patchset: https://codereview.chromium.org/2670163002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-02-03 16:25:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 16:29:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486139146495360,
"parent_rev": "a6efc1e4f6920dd1249ffb2bff3bf66ec6631e7d", "commit_rev":
"cdda2304436ad1731189aaa50ef55cd0773d0da6"}

[commit-bot: I haz the power, 2017-02-03 16:29:57]

Description was changed from

==========
Make wide logs an option in task-page

In narrow mode, the logs are wrapped.  In wide mode, they get a scrollbar if
they are too wide to fit on the screen.

This also fixes a bug where multiple spaces in a row were being collapsed
(whitespace: pre-line vs prewrap) which threw off alignment in logs.

BUG=672613
==========

to

==========
Make wide logs an option in task-page

In narrow mode, the logs are wrapped.  In wide mode, they get a scrollbar if
they are too wide to fit on the screen.

This also fixes a bug where multiple spaces in a row were being collapsed
(whitespace: pre-line vs prewrap) which threw off alignment in logs.

BUG=672613

Review-Url: https://codereview.chromium.org/2670163002
Committed:
https://github.com/luci/luci-py/commit/cdda2304436ad1731189aaa50ef55cd0773d0da6
==========

[commit-bot: I haz the power, 2017-02-03 16:29:58]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/cdda2304436ad1731189aaa50ef55cd0773d0da6