Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2670143004: Add flag for AIA fetching and enable on waterfall (Closed)

Created:
3 years, 10 months ago by estark
Modified:
3 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag for AIA fetching and enable on waterfall This CL adds a chrome://flags to enable AIA fetching on Android and also enables the feature on the waterfall. BUG=688272 Review-Url: https://codereview.chromium.org/2670143004 Cr-Commit-Position: refs/heads/master@{#448187} Committed: https://chromium.googlesource.com/chromium/src/+/92dc22973ed15b4e4683d4ac73ea329763f65c25

Patch Set 1 #

Patch Set 2 : update histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
estark
isherman, can you please review? Thanks!
3 years, 10 months ago (2017-02-04 00:32:46 UTC) #7
Ilya Sherman
LGTM
3 years, 10 months ago (2017-02-04 18:26:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670143004/20001
3 years, 10 months ago (2017-02-04 18:26:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-04 20:27:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670143004/20001
3 years, 10 months ago (2017-02-04 20:45:59 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-04 22:46:37 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670143004/20001
3 years, 10 months ago (2017-02-05 19:15:42 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-05 20:34:31 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92dc22973ed15b4e4683d4ac73ea...

Powered by Google App Engine
This is Rietveld 408576698