Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 26701002: Add swapBuffer call to SkGLContextHelper. (Closed)

Created:
7 years, 2 months ago by djsollen
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add swapBuffer call to SkGLContextHelper. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11682

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : null context #

Patch Set 4 : unix #

Patch Set 5 : ios #

Total comments: 1

Patch Set 6 : comment #

Patch Set 7 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
include/gpu/gl/SkANGLEGLContext.h View 1 chunk +1 line, -0 lines 0 comments Download
include/gpu/gl/SkDebugGLContext.h View 1 chunk +1 line, -0 lines 0 comments Download
include/gpu/gl/SkGLContextHelper.h View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
include/gpu/gl/SkMesaGLContext.h View 1 chunk +1 line, -0 lines 0 comments Download
include/gpu/gl/SkNativeGLContext.h View 1 chunk +1 line, -0 lines 0 comments Download
include/gpu/gl/SkNullGLContext.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
src/gpu/gl/android/SkNativeGLContext_android.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
src/gpu/gl/angle/SkANGLEGLContext.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
src/gpu/gl/iOS/SkNativeGLContext_iOS.mm View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
src/gpu/gl/mac/SkNativeGLContext_mac.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
src/gpu/gl/mesa/SkMesaGLContext.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
src/gpu/gl/nacl/SkNativeGLContext_nacl.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
src/gpu/gl/unix/SkNativeGLContext_unix.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
src/gpu/gl/win/SkNativeGLContext_win.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
djsollen
nothing exercises this code yet so I can't fully test it yet, but I will ...
7 years, 2 months ago (2013-10-09 18:12:41 UTC) #1
bsalomon
lgtm with one comment suggestion https://codereview.chromium.org/26701002/diff/14001/include/gpu/gl/SkGLContextHelper.h File include/gpu/gl/SkGLContextHelper.h (right): https://codereview.chromium.org/26701002/diff/14001/include/gpu/gl/SkGLContextHelper.h#newcode41 include/gpu/gl/SkGLContextHelper.h:41: * call has no ...
7 years, 2 months ago (2013-10-09 18:17:08 UTC) #2
djsollen
7 years, 2 months ago (2013-10-09 18:25:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 manually as r11682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698