[Download Home] Displaying offline page bundle per day

chrome/android/java/res/layout/offline_download_header.xml

Index: chrome/android/java/res/layout/offline_download_header.xml
diff --git a/chrome/android/java/res/layout/offline_download_header.xml b/chrome/android/java/res/layout/offline_download_header.xml
new file mode 100644
index 0000000000000000000000000000000000000000..055f721e6aa77db691baafef6fbf656cae22b253
--- /dev/null
+++ b/chrome/android/java/res/layout/offline_download_header.xml
@@ -0,0 +1,92 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+     Use of this source code is governed by a BSD-style license that can be
+     found in the LICENSE file. -->
+
+<!-- Represents the offline pages group header in the DownloadHistoryAdapterView. --> 
+<view class="org.chromium.chrome.browser.download.ui.OfflineGroupHeaderView"
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:chrome="http://schemas.android.com/apk/res-auto"
+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content" >
+
+    <LinearLayout
+            android:id="@+id/layout_container"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:layout_marginStart="16dp"
+            android:layout_marginTop="16dp"
+            android:layout_marginBottom="16dp"
+            android:gravity="center_vertical"
+            android:orientation="horizontal" >
+
+        <org.chromium.chrome.browser.widget.TintedImageView
+                android:id="@+id/icon_view"
+                android:layout_width="@dimen/downloads_item_icon_size"
+                android:layout_height="@dimen/downloads_item_icon_size"
+                android:layout_marginEnd="16dp"
+                android:contentDescription="@null"
+                android:scaleType="center"
+                android:src="@drawable/ic_drive_site_white_24dp"
+                android:background="@color/light_active_color" />
+
+        <RelativeLayout
+                android:id="@+id/completed_layout"
+                android:layout_width="0dp"
+                android:layout_height="wrap_content"
+                android:layout_weight="1" >
+    
+            <TextView
+                    android:id="@+id/page_count_text"
+                    android:layout_width="wrap_content"
+                    android:layout_height="wrap_content"
+                    android:layout_alignParentTop="true"
+                    android:layout_alignParentStart="true"
+                    android:paddingEnd="16dp"
+                    android:singleLine="true"
+                    android:textColor="@color/default_text_color"
+                    android:textSize="16sp" />
+
+            <TextView
+                    android:id="@+id/description"
+                    android:layout_width="wrap_content"
+                    android:layout_height="wrap_content"
+                    android:layout_alignParentBottom="true"
+                    android:layout_alignParentStart="true"
+                    android:layout_toStartOf="@+id/filesize_view"

[gone, 2017/02/02 23:59:47]

move this to a layout_toEndOf rule on filesize_view so that everything that
comes later in the file depends on the things before it

[shaktisahu, 2017/02/04 18:57:42]

I followed the same code as download_item_view.xml. I guess the description
could be longer than the available space overlap with the  filesize_view. That's
why filesize_view needs to be drawn first ?

+                    android:layout_below="@+id/page_count_text"
+                    android:layout_marginEnd="16dp"
+                    android:layout_marginTop="0dp"
+                    android:textAlignment="viewStart"
+                    android:textColor="@color/google_grey_600"
+                    android:ellipsize="start"
+                    android:singleLine="true" />
+
+            <TextView
+                    android:id="@+id/filesize_view"
+                    android:layout_width="wrap_content"
+                    android:layout_height="wrap_content"
+                    android:layout_alignParentBottom="true"
+                    android:layout_alignParentEnd="true"
+                    android:layout_below="@+id/page_count_text"
+                    android:layout_marginTop="0dp"
+                    android:paddingEnd="16dp"
+                    android:textAlignment="viewEnd"
+                    android:textColor="@color/google_grey_600"
+                    android:singleLine="true" />
+
+            <ImageView

[gone, 2017/02/02 23:59:47]

This view is just dangling here; it can end up overlapping the view that is
below it.

1) It should be placed above the description textview.
2) It needs to be layout_alignBottom with the page_count_text.
3) filesize_view should be layout_below expand_icon

[shaktisahu, 2017/02/04 18:57:42]

Done.
1- Done
2- It has alignParentTop instead.
3- Not necessarily, since filesize_view also has alignParentBottom. Moreover the
icon is not directly above the file size text.

+                    android:id="@+id/expand_icon"
+                    android:layout_width="wrap_content"
+                    android:layout_height="wrap_content"
+                    android:layout_alignParentTop="true"
+                    android:layout_toEndOf="@+id/page_count_text"
+                    android:layout_marginTop="0dp"
+                    android:paddingEnd="16dp"
+                    android:contentDescription="@null"
+                    android:src="@drawable/ic_expanded" />
+
+        </RelativeLayout>
+    
+    </LinearLayout>

[gone, 2017/02/02 23:59:47]

This really needs a screenshot to be reviewed properly.

[shaktisahu, 2017/02/04 18:57:42]

The screenshot should be same as 
https://docs.google.com/presentation/d/13k5aqrflvb6GohGd_xjM2JeSZtF3A665HgUn7...

+</view>