chrome/android/java/res/layout/offline_download_header.xml - Issue 2670083002: [Download Home] Displaying offline page bundle per day

Side by Side Diff: chrome/android/java/res/layout/offline_download_header.xml

Issue 2670083002: [Download Home] Displaying offline page bundle per day (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Represents the offline pages group header in the DownloadHistoryAdapterView . -->

	7 <view class="org.chromium.chrome.browser.download.ui.OfflineGroupHeaderView"

	8 xmlns:android="http://schemas.android.com/apk/res/android"

	9 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	10 android:layout_width="wrap_content"

	11 android:layout_height="wrap_content" >

	12

	13 <LinearLayout

	14 android:id="@+id/layout_container"

	15 android:layout_width="match_parent"

	16 android:layout_height="wrap_content"

	17 android:layout_marginStart="16dp"

	18 android:layout_marginTop="16dp"

	19 android:layout_marginBottom="16dp"

	20 android:gravity="center_vertical"

	21 android:orientation="horizontal" >

	22

	23 <org.chromium.chrome.browser.widget.TintedImageView

	24 android:id="@+id/icon_view"

	25 android:layout_width="@dimen/downloads_item_icon_size"

	26 android:layout_height="@dimen/downloads_item_icon_size"

	27 android:layout_marginEnd="16dp"

	28 android:contentDescription="@null"

	29 android:scaleType="center"

	30 android:src="@drawable/ic_drive_site_white_24dp"

	31 android:background="@color/light_active_color" />

	32

	33 <RelativeLayout

	34 android:id="@+id/completed_layout"

	35 android:layout_width="0dp"

	36 android:layout_height="wrap_content"

	37 android:layout_weight="1" >

	38

	39 <TextView

	40 android:id="@+id/page_count_text"

	41 android:layout_width="wrap_content"

	42 android:layout_height="wrap_content"

	43 android:layout_alignParentTop="true"

	44 android:layout_alignParentStart="true"

	45 android:paddingEnd="16dp"

	46 android:singleLine="true"

	47 android:textColor="@color/default_text_color"

	48 android:textSize="16sp" />

	49

	50 <TextView

	51 android:id="@+id/description"

	52 android:layout_width="wrap_content"

	53 android:layout_height="wrap_content"

	54 android:layout_alignParentBottom="true"

	55 android:layout_alignParentStart="true"

	56 android:layout_toStartOf="@+id/filesize_view"
	gone 2017/02/02 23:59:47 move this to a layout_toEndOf rule on filesize_vie move this to a layout_toEndOf rule on filesize_view so that everything that comes later in the file depends on the things before it shaktisahu 2017/02/04 18:57:42 I followed the same code as download_item_view.xml Show quoted text On 2017/02/02 23:59:47, dfalcantara (load balance plz) wrote: > move this to a layout_toEndOf rule on filesize_view so that everything that > comes later in the file depends on the things before it I followed the same code as download_item_view.xml. I guess the description could be longer than the available space overlap with the filesize_view. That's why filesize_view needs to be drawn first ?
	57 android:layout_below="@+id/page_count_text"

	58 android:layout_marginEnd="16dp"

	59 android:layout_marginTop="0dp"

	60 android:textAlignment="viewStart"

	61 android:textColor="@color/google_grey_600"

	62 android:ellipsize="start"

	63 android:singleLine="true" />

	64

	65 <TextView

	66 android:id="@+id/filesize_view"

	67 android:layout_width="wrap_content"

	68 android:layout_height="wrap_content"

	69 android:layout_alignParentBottom="true"

	70 android:layout_alignParentEnd="true"

	71 android:layout_below="@+id/page_count_text"

	72 android:layout_marginTop="0dp"

	73 android:paddingEnd="16dp"

	74 android:textAlignment="viewEnd"

	75 android:textColor="@color/google_grey_600"

	76 android:singleLine="true" />

	77

	78 <ImageView
	gone 2017/02/02 23:59:47 This view is just dangling here; it can end up ove This view is just dangling here; it can end up overlapping the view that is below it. 1) It should be placed above the description textview. 2) It needs to be layout_alignBottom with the page_count_text. 3) filesize_view should be layout_below expand_icon shaktisahu 2017/02/04 18:57:42 Done. 1- Done 2- It has alignParentTop instead. 3- Show quoted text On 2017/02/02 23:59:47, dfalcantara (load balance plz) wrote: > This view is just dangling here; it can end up overlapping the view that is > below it. > > 1) It should be placed above the description textview. > 2) It needs to be layout_alignBottom with the page_count_text. > 3) filesize_view should be layout_below expand_icon Done. 1- Done 2- It has alignParentTop instead. 3- Not necessarily, since filesize_view also has alignParentBottom. Moreover the icon is not directly above the file size text.
	79 android:id="@+id/expand_icon"

	80 android:layout_width="wrap_content"

	81 android:layout_height="wrap_content"

	82 android:layout_alignParentTop="true"

	83 android:layout_toEndOf="@+id/page_count_text"

	84 android:layout_marginTop="0dp"

	85 android:paddingEnd="16dp"

	86 android:contentDescription="@null"

	87 android:src="@drawable/ic_expanded" />

	88

	89 </RelativeLayout>

	90

	91 </LinearLayout>
	gone 2017/02/02 23:59:47 This really needs a screenshot to be reviewed prop This really needs a screenshot to be reviewed properly. shaktisahu 2017/02/04 18:57:42 The screenshot should be same as https://docs.goo Show quoted text On 2017/02/02 23:59:47, dfalcantara (load balance plz) wrote: > This really needs a screenshot to be reviewed properly. The screenshot should be same as https://docs.google.com/presentation/d/13k5aqrflvb6GohGd_xjM2JeSZtF3A665HgUn7...
	92 </view>

OLD	NEW