Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2670003005: Convert biquadfilternode-basic test to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert biquadfilternode-basic test to testharness Manually convert test to testharness and new Audit. Update expected result file since there's an console log message. BUG=687307 TEST=biquadfilternode-basic.html Review-Url: https://codereview.chromium.org/2670003005 Cr-Commit-Position: refs/heads/master@{#448385} Committed: https://chromium.googlesource.com/chromium/src/+/ebd02bafbf4a71ca89c81dd2d27a1319a4e5911a

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments. #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -111 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html View 1 1 chunk +47 lines, -88 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic-expected.txt View 1 2 1 chunk +30 lines, -23 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-03 16:44:57 UTC) #2
hongchan
lgtm with nits https://codereview.chromium.org/2670003005/diff/1/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html File third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html (right): https://codereview.chromium.org/2670003005/diff/1/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html#newcode15 third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html:15: task.describe("Basic tests for BiquadFilterNode"); 4 spaces ...
3 years, 10 months ago (2017-02-06 17:33:02 UTC) #3
Raymond Toy
https://codereview.chromium.org/2670003005/diff/1/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html File third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html (right): https://codereview.chromium.org/2670003005/diff/1/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html#newcode15 third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html:15: task.describe("Basic tests for BiquadFilterNode"); On 2017/02/06 17:33:02, hongchan wrote: ...
3 years, 10 months ago (2017-02-06 18:08:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670003005/20001
3 years, 10 months ago (2017-02-06 18:09:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/376985)
3 years, 10 months ago (2017-02-06 19:12:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670003005/40001
3 years, 10 months ago (2017-02-06 19:47:04 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 21:04:16 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ebd02bafbf4a71ca89c81dd2d27a...

Powered by Google App Engine
This is Rietveld 408576698