Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2670003004: [Media Router] Erase PresentationFrame entry when corresponding RenderFrameHost is gone (Closed)

Created:
3 years, 10 months ago by imcheng
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Media Router] Erase PresentationFrame entry when corresponding RenderFrameHost is gone In PresentationServiceDelegateImpl::RemoveObserver(), we should also erase PresentationFrame entry from PresentationFrameManager. BUG=685879 Review-Url: https://codereview.chromium.org/2657613007 Cr-Commit-Position: refs/heads/master@{#447040} (cherry picked from commit 433b648885b0b665053a43f8cd603dc52ccb44c2) Review-Url: https://codereview.chromium.org/2670003004 . Cr-Commit-Position: refs/branch-heads/2987@{#282} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/136f664d94b8f6dce81dff132071845aad96fda6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 5 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
imcheng
3 years, 10 months ago (2017-02-02 21:30:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
136f664d94b8f6dce81dff132071845aad96fda6.

Powered by Google App Engine
This is Rietveld 408576698