Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2670003003: PPC/s390: [stubs] Also port the CallICStub to CSA. (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [stubs] Also port the CallICStub to CSA. Port d68dfe861931fb9614700ba195a304deaa499021 Original Commit Message: Port the Call feedback machinery from the interpreter to the CallICStub as second step to unify the feedback collection. This removes a lot of hand-written native code, and makes the runtime miss handler obsolete. The next step will be to use the CallICStub from the interpreter as well. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5049 LOG=N Review-Url: https://codereview.chromium.org/2670003003 Cr-Commit-Position: refs/heads/master@{#42896} Committed: https://chromium.googlesource.com/v8/v8/+/fecba0dcca8d9689005d220f34a47442f1c71c69

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix mov instr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -368 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -184 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -182 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-02 15:45:43 UTC) #1
john.yan
lgtm with nit https://codereview.chromium.org/2670003003/diff/1/src/full-codegen/s390/full-codegen-s390.cc File src/full-codegen/s390/full-codegen-s390.cc (right): https://codereview.chromium.org/2670003003/diff/1/src/full-codegen/s390/full-codegen-s390.cc#newcode1863 src/full-codegen/s390/full-codegen-s390.cc:1863: __ mov(r5, Operand(IntFromSlot(expr->CallFeedbackICSlot()))); using Load() is ...
3 years, 10 months ago (2017-02-02 16:02:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670003003/20001
3 years, 10 months ago (2017-02-02 16:56:38 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 18:16:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/fecba0dcca8d9689005d220f34a47442f1c...

Powered by Google App Engine
This is Rietveld 408576698