Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 26700002: remove tracking code, as it polutes the code readability. Should be added back, in a less eficient … (Closed)

Created:
7 years, 2 months ago by edisonn
Modified:
7 years, 2 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove tracking code, as it polutes the code readability. Should be added back, in a less eficient way, by registering streams instead, so we don't have to pass arround the streams, and the code will be cleaner. Committed: https://code.google.com/p/skia/source/detail?r=11671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -222 lines) Patch
M experimental/PdfViewer/SkPdfConfig.h View 2 chunks +23 lines, -32 lines 0 comments Download
M experimental/PdfViewer/pdf_viewer_main.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.cpp View 14 chunks +25 lines, -22 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.h View 6 chunks +48 lines, -63 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.h View 3 chunks +3 lines, -7 lines 0 comments Download
M experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp View 20 chunks +82 lines, -93 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
edisonn
7 years, 2 months ago (2013-10-09 15:13:23 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r11671 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698