experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp - Issue 26700002: remove tracking code, as it polutes the code readability. Should be added back, in a less eficient …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp

Issue 26700002: remove tracking code, as it polutes the code readability. Should be added back, in a less eficient … (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.h ('k') | experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp

===================================================================

--- experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp (revision 11625)

+++ experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp (working copy)

@@ -20,7 +20,7 @@

#include "SkPdfReporter.h"

-SkPdfNativeObject SkPdfNativeObject::kNull = SkPdfNativeObject::makeNull(PUT_TRACK_PARAMETERS_SRC0);

+SkPdfNativeObject SkPdfNativeObject::kNull = SkPdfNativeObject::makeNull();

bool SkPdfNativeObject::applyFlateDecodeFilter() {

if (!SkFlate::HaveFlate()) {

@@ -106,7 +106,7 @@

void SkPdfNativeObject::releaseData() {

#ifdef PDF_TRACK_OBJECT_USAGE

- SkPdfReportIf(!fUsed, kInfo_SkPdfIssueSeverity, NULL, this, "Unused object in rendering");

+ SkPdfReportIf(!fUsed, kInfo_SkPdfIssueSeverity, kNoIssue_SkPdfIssue, "Unused object in rendering", this, NULL);

#endif // PDF_TRACK_OBJECT_USAGE

SkPdfMarkObjectUnused();