Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2669973003: Cleanup: Remove unused stuff from InstantTestUtils (Closed)

Created:
3 years, 10 months ago by Marc Treib
Modified:
3 years, 10 months ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused stuff from InstantTestUtils BUG=627747 Review-Url: https://codereview.chromium.org/2669973003 Cr-Commit-Position: refs/heads/master@{#447751} Committed: https://chromium.googlesource.com/chromium/src/+/a5d0ce613e889795f21667d99e7c080292bcdbe8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -61 lines) Patch
M chrome/browser/ui/search/instant_test_utils.h View 5 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 5 chunks +1 line, -37 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Marc Treib
Whenever I touch anything Instant-related, I have this urge to delete all the obsolete crap ...
3 years, 10 months ago (2017-02-02 12:15:04 UTC) #6
sfiera
LGTM https://youtu.be/2Oy6DwHAi70
3 years, 10 months ago (2017-02-02 12:36:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669973003/1
3 years, 10 months ago (2017-02-02 12:49:37 UTC) #9
Marc Treib
On 2017/02/02 12:36:16, sfiera wrote: > LGTM https://youtu.be/2Oy6DwHAi70 :D One ray of light: There are ...
3 years, 10 months ago (2017-02-02 12:50:56 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 12:57:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a5d0ce613e889795f21667d99e7c...

Powered by Google App Engine
This is Rietveld 408576698