Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2669953003: Add TEAM and COMPONENT annotations to net/ OWNERS files. (Closed)

Created:
3 years, 10 months ago by Bence
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org, eroman, Paweł Hajdan Jr., bnc+watch_chromium.org, mmenke, ymzhang1, sshruthi1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TEAM and COMPONENT annotations to net/ OWNERS files. Review-Url: https://codereview.chromium.org/2669953003 Cr-Commit-Position: refs/heads/master@{#448110} Committed: https://chromium.googlesource.com/chromium/src/+/0e05b275042fd6114f705d341a24f58c8e6cec4a

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix component names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M net/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A net/cert/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A net/cert_net/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/cookies/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A net/disk_cache/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/simple/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/dns/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A net/filter/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A net/http2/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A net/log/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A net/quic/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A net/sdch/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A net/spdy/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A net/ssl/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Bence
https://codereview.chromium.org/2669953003/diff/1/net/quic/OWNERS File net/quic/OWNERS (right): https://codereview.chromium.org/2669953003/diff/1/net/quic/OWNERS#newcode1 net/quic/OWNERS:1: # COMPONENT: Internals>QUIC Would # TEAM: proto-quic@chromium.org be appropriate ...
3 years, 10 months ago (2017-02-02 14:38:44 UTC) #1
xunjieli
https://codereview.chromium.org/2669953003/diff/1/net/cert/OWNERS File net/cert/OWNERS (right): https://codereview.chromium.org/2669953003/diff/1/net/cert/OWNERS#newcode1 net/cert/OWNERS:1: # COMPONENT: Internals>Certificate Do you mean Internals>Network>Certificate?
3 years, 10 months ago (2017-02-02 15:03:13 UTC) #2
Bence
https://codereview.chromium.org/2669953003/diff/1/net/cert/OWNERS File net/cert/OWNERS (right): https://codereview.chromium.org/2669953003/diff/1/net/cert/OWNERS#newcode1 net/cert/OWNERS:1: # COMPONENT: Internals>Certificate On 2017/02/02 15:03:12, xunjieli wrote: > ...
3 years, 10 months ago (2017-02-02 15:16:43 UTC) #3
Ryan Hamilton
https://codereview.chromium.org/2669953003/diff/1/net/quic/OWNERS File net/quic/OWNERS (right): https://codereview.chromium.org/2669953003/diff/1/net/quic/OWNERS#newcode1 net/quic/OWNERS:1: # COMPONENT: Internals>QUIC On 2017/02/02 14:38:44, Bence wrote: > ...
3 years, 10 months ago (2017-02-02 23:41:14 UTC) #5
Bence
Thanks. https://codereview.chromium.org/2669953003/diff/1/net/quic/OWNERS File net/quic/OWNERS (right): https://codereview.chromium.org/2669953003/diff/1/net/quic/OWNERS#newcode1 net/quic/OWNERS:1: # COMPONENT: Internals>QUIC On 2017/02/02 23:41:14, Ryan Hamilton ...
3 years, 10 months ago (2017-02-03 00:18:42 UTC) #6
Ryan Hamilton
lgtm
3 years, 10 months ago (2017-02-03 18:31:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669953003/20001
3 years, 10 months ago (2017-02-03 23:46:34 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 00:04:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e05b275042fd6114f705d341a24...

Powered by Google App Engine
This is Rietveld 408576698