Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2669933003: Merged: Fix uncaught exception bug from liveEditScriptSource (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: Fix uncaught exception bug from liveEditScriptSource Revision: a81fbe802a605a4f098b2df00e9d60eabeac5168 BUG=chromium:683335 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2669933003 . Cr-Commit-Position: refs/branch-heads/5.7@{#86} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/f9481b4996c6ffe96e41834c633ed656835a6d80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -9 lines) Patch
M src/inspector/v8-debugger.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/inspector/v8-debugger.cc View 8 chunks +12 lines, -8 lines 0 comments Download
A test/inspector/debugger/set-script-source-exception.js View 1 chunk +23 lines, -0 lines 0 comments Download
A test/inspector/debugger/set-script-source-exception-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kozy
3 years, 10 months ago (2017-02-02 22:44:20 UTC) #1
kozy
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-02 22:44:21 UTC) #2
ulan
lgtm
3 years, 10 months ago (2017-02-02 22:46:03 UTC) #3
kozy
3 years, 10 months ago (2017-02-02 22:46:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f9481b4996c6ffe96e41834c633ed656835a6d80.

Powered by Google App Engine
This is Rietveld 408576698