Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2196)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2669923002: MD Settings: Change search engine add button to a paper-button (Closed)
Patch Set: make the css selector for paper-button more precise Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/search_engines_page_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
index e2d682d2f5d73f272ebcb4f066f37b08aa98c154..302f9b6e12fb003ef91bb348e772dfe13a33d959 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
@@ -23,6 +23,10 @@
settings-omnibox-extension-entry:first-of-type {
border-top: none;
}
+
+ .settings-box > h2 + paper-button {
+ margin-top: 12px; /* Align with <h2>. */
+ }
</style>
<div class="settings-box first">
<h2>$i18n{searchEnginesDefault}</h2>
@@ -32,17 +36,16 @@
<template is="dom-if" if="[[showAddSearchEngineDialog_]]" restamp>
<settings-search-engine-dialog></settings-search-engine-dialog>
</template>
+
<div class="settings-box first">
- <h2>$i18n{searchEnginesOther}</h2>
+ <h2 class="start">$i18n{searchEnginesOther}</h2>
+ <paper-button class="secondary-button" on-tap="onAddSearchEngineTap_"
+ id="addSearchEngine">
+ $i18n{add}
+ </paper-button>
</div>
<settings-search-engines-list engines="[[otherEngines]]">
- <div class="list-item" id="addSearchEngine">
- <a is="action-link" class="list-button" on-tap="onAddSearchEngineTap_">
- $i18n{searchEnginesAddSearchEngine}
tommycli 2017/02/02 00:12:55 if not used, remove from grd and cc. Also... if t
scottchen 2017/02/02 01:40:58 Looks like it's still used here: https://cs.chromi
- </a>
- </div>
</settings-search-engines-list>
-
<template is="dom-if" if="[[showExtensionsList_]]">
<div class="settings-box first">
<h2>$i18n{searchEnginesExtension}</h2>
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/search_engines_page_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698