Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2669893002: Initialize TaskScheduler in remoting processes. (Closed)

Created:
3 years, 10 months ago by Sergey Ulanov
Modified:
3 years, 10 months ago
Reviewers:
fdoray, nicholss, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize TaskScheduler in remoting processes. Added TaskScheduler initialization in the following processes: 1. It2Me host. 2. Me2Me host. 3. Me2Me native messaging host. 4. Android client. 5. iOS client. BUG=687692 Review-Url: https://codereview.chromium.org/2669893002 Cr-Commit-Position: refs/heads/master@{#447676} Committed: https://chromium.googlesource.com/chromium/src/+/7df3c119b83d5b30eb201c7310141e4f87a326d1

Patch Set 1 #

Total comments: 2

Patch Set 2 : TODOs #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -22 lines) Patch
M remoting/client/ios/app_runtime.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_main.cc View 1 4 chunks +12 lines, -11 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_main.cc View 1 2 4 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Sergey Ulanov
3 years, 10 months ago (2017-02-01 23:12:45 UTC) #2
Sergey Ulanov
+fdoray
3 years, 10 months ago (2017-02-01 23:13:28 UTC) #4
nicholss
LGTM
3 years, 10 months ago (2017-02-01 23:14:47 UTC) #5
joedow
lgtm https://codereview.chromium.org/2669893002/diff/1/remoting/client/jni/chromoting_jni_runtime.cc File remoting/client/jni/chromoting_jni_runtime.cc (right): https://codereview.chromium.org/2669893002/diff/1/remoting/client/jni/chromoting_jni_runtime.cc#newcode46 remoting/client/jni/chromoting_jni_runtime.cc:46: const int kMaxBackgroundThreads = 5; I see that ...
3 years, 10 months ago (2017-02-01 23:20:43 UTC) #6
Sergey Ulanov
https://codereview.chromium.org/2669893002/diff/1/remoting/client/jni/chromoting_jni_runtime.cc File remoting/client/jni/chromoting_jni_runtime.cc (right): https://codereview.chromium.org/2669893002/diff/1/remoting/client/jni/chromoting_jni_runtime.cc#newcode46 remoting/client/jni/chromoting_jni_runtime.cc:46: const int kMaxBackgroundThreads = 5; On 2017/02/01 23:20:42, joedow ...
3 years, 10 months ago (2017-02-02 00:14:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669893002/20001
3 years, 10 months ago (2017-02-02 00:15:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/162596)
3 years, 10 months ago (2017-02-02 00:29:05 UTC) #12
Sergey Ulanov
comp
3 years, 10 months ago (2017-02-02 01:28:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669893002/40001
3 years, 10 months ago (2017-02-02 01:29:27 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 01:41:31 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7df3c119b83d5b30eb201c731014...

Powered by Google App Engine
This is Rietveld 408576698