Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: chrome/browser/android/preferences/pref_service_bridge.cc

Issue 2669873002: [ImportantSites] Implementing dialog level blacklisting and blacklist expiration (Closed)
Patch Set: Comments, still no tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/preferences/pref_service_bridge.cc
diff --git a/chrome/browser/android/preferences/pref_service_bridge.cc b/chrome/browser/android/preferences/pref_service_bridge.cc
index 7f50a0bdeca2b85fc637aabfd633a25f9fdc0fcd..ab27e84245d42e1cb00accd1299fb2359a1d2f54 100644
--- a/chrome/browser/android/preferences/pref_service_bridge.cc
+++ b/chrome/browser/android/preferences/pref_service_bridge.cc
@@ -701,9 +701,11 @@ static jboolean CanDeleteBrowsingHistory(JNIEnv* env,
static void FetchImportantSites(JNIEnv* env,
const JavaParamRef<jclass>& clazz,
const JavaParamRef<jobject>& java_callback) {
+ Profile* profile = GetOriginalProfile();
std::vector<ImportantSitesUtil::ImportantDomainInfo> important_sites =
- ImportantSitesUtil::GetImportantRegisterableDomains(GetOriginalProfile(),
+ ImportantSitesUtil::GetImportantRegisterableDomains(profile,
kMaxImportantSites);
+ bool dialog_disabled = ImportantSitesUtil::IsDialogDisabled(profile);
std::vector<std::string> important_domains;
std::vector<int32_t> important_domain_reasons;
@@ -723,7 +725,7 @@ static void FetchImportantSites(JNIEnv* env,
Java_ImportantSitesCallback_onImportantRegisterableDomainsReady(
env, java_callback.obj(), java_domains.obj(), java_origins.obj(),
- java_reasons.obj());
+ java_reasons.obj(), dialog_disabled);
}
// This value should not change during a sessions, as it's used for UMA metrics.

Powered by Google App Engine
This is Rietveld 408576698