Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1975)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

Issue 2669873002: [ImportantSites] Implementing dialog level blacklisting and blacklist expiration (Closed)
Patch Set: Comments, still no tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
index def7a49fe00e39400f76608edbfa65d894b4af46..5d11891c62fec324b38b9ab412b0c3fcf065fa7d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
@@ -92,10 +92,13 @@ public final class PrefServiceBridge {
* favicons.
* @param importantReasons Bitfield of reasons why this domain was selected. Pass this back
* to clearBrowinsgData so we can record metrics.
+ * @param dialogDisabled If the important dialog itself is blacklisted and shouldn't be
dominickn 2017/02/03 19:30:53 You could clarify this comment ("blacklisting" a d
dmurph 2017/02/03 20:03:29 Done.
dmurph 2017/02/03 20:03:29 Done.
+ * shown.
*/
@CalledByNative("ImportantSitesCallback")
void onImportantRegisterableDomainsReady(
- String[] domains, String[] exampleOrigins, int[] importantReasons);
+ String[] domains, String[] exampleOrigins, int[] importantReasons,
+ boolean dialogBlacklisted);
dominickn 2017/02/03 19:30:53 Nit: dialogDisabled, not dialogBlacklisted. The fo
dmurph 2017/02/03 20:03:29 Done.
}
/**

Powered by Google App Engine
This is Rietveld 408576698