Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2669703003: Refactor ConstantExpression/ConstantConstructor to use entities. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor ConstantExpression/ConstantConstructor to use entities. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b789a27f0575527980f4e944de9600181f87cfac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -247 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 9 chunks +37 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/constants/constructors.dart View 8 chunks +49 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 33 chunks +117 lines, -70 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/constant_visitor.dart View 3 chunks +10 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_adapter.dart View 4 chunks +59 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 9 chunks +12 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 10 chunks +47 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 2 chunks +0 lines, -68 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_dart2js_helpers_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 2 chunks +23 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_test.dart View 5 chunks +6 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-01 15:29:40 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-01 23:44:11 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-02 09:12:34 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b789a27f0575527980f4e944de9600181f87cfac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698