Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2669703003: Refactor ConstantExpression/ConstantConstructor to use entities. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:collection'; 5 import 'dart:collection';
6 6
7 import 'package:js_runtime/shared/embedded_names.dart'; 7 import 'package:js_runtime/shared/embedded_names.dart';
8 8
9 import '../closure.dart'; 9 import '../closure.dart';
10 import '../common.dart'; 10 import '../common.dart';
(...skipping 4719 matching lines...) Expand 10 before | Expand all | Expand 10 after
4730 4730
4731 @override 4731 @override
4732 void visitUnresolvedSet(ast.SendSet node, Element element, ast.Node rhs, _) { 4732 void visitUnresolvedSet(ast.SendSet node, Element element, ast.Node rhs, _) {
4733 generateIsDeferredLoadedCheckOfSend(node); 4733 generateIsDeferredLoadedCheckOfSend(node);
4734 generateNonInstanceSetter(node, element, visitAndPop(rhs)); 4734 generateNonInstanceSetter(node, element, visitAndPop(rhs));
4735 } 4735 }
4736 4736
4737 @override 4737 @override
4738 void visitClassTypeLiteralSet( 4738 void visitClassTypeLiteralSet(
4739 ast.SendSet node, TypeConstantExpression constant, ast.Node rhs, _) { 4739 ast.SendSet node, TypeConstantExpression constant, ast.Node rhs, _) {
4740 generateThrowNoSuchMethod(node, constant.type.name, 4740 generateThrowNoSuchMethod(node, constant.name,
4741 argumentNodes: node.arguments); 4741 argumentNodes: node.arguments);
4742 } 4742 }
4743 4743
4744 @override 4744 @override
4745 void visitTypedefTypeLiteralSet( 4745 void visitTypedefTypeLiteralSet(
4746 ast.SendSet node, TypeConstantExpression constant, ast.Node rhs, _) { 4746 ast.SendSet node, TypeConstantExpression constant, ast.Node rhs, _) {
4747 generateThrowNoSuchMethod(node, constant.type.name, 4747 generateThrowNoSuchMethod(node, constant.name,
4748 argumentNodes: node.arguments); 4748 argumentNodes: node.arguments);
4749 } 4749 }
4750 4750
4751 @override 4751 @override
4752 void visitDynamicTypeLiteralSet( 4752 void visitDynamicTypeLiteralSet(
4753 ast.SendSet node, TypeConstantExpression constant, ast.Node rhs, _) { 4753 ast.SendSet node, TypeConstantExpression constant, ast.Node rhs, _) {
4754 generateThrowNoSuchMethod(node, constant.type.name, 4754 generateThrowNoSuchMethod(node, constant.name,
4755 argumentNodes: node.arguments); 4755 argumentNodes: node.arguments);
4756 } 4756 }
4757 4757
4758 @override 4758 @override
4759 void visitTypeVariableTypeLiteralSet( 4759 void visitTypeVariableTypeLiteralSet(
4760 ast.SendSet node, TypeVariableElement element, ast.Node rhs, _) { 4760 ast.SendSet node, TypeVariableElement element, ast.Node rhs, _) {
4761 generateThrowNoSuchMethod(node, element.name, 4761 generateThrowNoSuchMethod(node, element.name,
4762 argumentNodes: node.arguments); 4762 argumentNodes: node.arguments);
4763 } 4763 }
4764 4764
(...skipping 1958 matching lines...) Expand 10 before | Expand all | Expand 10 after
6723 this.oldReturnLocal, 6723 this.oldReturnLocal,
6724 this.oldReturnType, 6724 this.oldReturnType,
6725 this.oldResolvedAst, 6725 this.oldResolvedAst,
6726 this.oldStack, 6726 this.oldStack,
6727 this.oldLocalsHandler, 6727 this.oldLocalsHandler,
6728 this.inTryStatement, 6728 this.inTryStatement,
6729 this.allFunctionsCalledOnce, 6729 this.allFunctionsCalledOnce,
6730 this.oldElementInferenceResults) 6730 this.oldElementInferenceResults)
6731 : super(function); 6731 : super(function);
6732 } 6732 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/serialization/equivalence.dart ('k') | pkg/compiler/lib/src/ssa/builder_kernel.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698