Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2669643002: Convert PopupBlockerTabHelper to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert PopupBlockerTabHelper to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2669643002 Cr-Commit-Position: refs/heads/master@{#447516} Committed: https://chromium.googlesource.com/chromium/src/+/a0e36f28d8b4ce27eb8e77330cbe379c6a032e4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-01-31 23:00:12 UTC) #5
Bernhard Bauer
lgtm
3 years, 10 months ago (2017-02-01 13:18:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669643002/1
3 years, 10 months ago (2017-02-01 15:32:55 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 15:38:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0e36f28d8b4ce27eb8e77330cbe...

Powered by Google App Engine
This is Rietveld 408576698