Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2669593003: DevTools: npm test - add --target=SUB_DIRECTORY_NAME (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: npm test - add --target=SUB_DIRECTORY_NAME See readme for how-to use. BUG=none Review-Url: https://codereview.chromium.org/2669593003 Cr-Commit-Position: refs/heads/master@{#447935} Committed: https://chromium.googlesource.com/chromium/src/+/16c41931e1bcdcb640c5cd8285020da30ab872f4

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/readme.md View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/npm_test.js View 7 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
chenwilliam
ptal https://codereview.chromium.org/2669593003/diff/1/third_party/WebKit/Source/devtools/readme.md File third_party/WebKit/Source/devtools/readme.md (right): https://codereview.chromium.org/2669593003/diff/1/third_party/WebKit/Source/devtools/readme.md#newcode103 third_party/WebKit/Source/devtools/readme.md:103: #### `--target=SUB_DIRECTORY_NAME` I know layout tests does it ...
3 years, 10 months ago (2017-01-31 22:52:02 UTC) #2
chenwilliam
@einbinder, ptal.
3 years, 10 months ago (2017-02-01 23:44:30 UTC) #5
einbinder
lgtm
3 years, 10 months ago (2017-02-02 20:39:51 UTC) #6
chenwilliam
@dgozman, ptal.
3 years, 10 months ago (2017-02-02 21:47:33 UTC) #8
dgozman
lgtm https://codereview.chromium.org/2669593003/diff/1/third_party/WebKit/Source/devtools/readme.md File third_party/WebKit/Source/devtools/readme.md (right): https://codereview.chromium.org/2669593003/diff/1/third_party/WebKit/Source/devtools/readme.md#newcode107 third_party/WebKit/Source/devtools/readme.md:107: # (e.g. if you're using out/Default) This line ...
3 years, 10 months ago (2017-02-02 22:10:00 UTC) #9
chenwilliam
https://codereview.chromium.org/2669593003/diff/1/third_party/WebKit/Source/devtools/readme.md File third_party/WebKit/Source/devtools/readme.md (right): https://codereview.chromium.org/2669593003/diff/1/third_party/WebKit/Source/devtools/readme.md#newcode107 third_party/WebKit/Source/devtools/readme.md:107: # (e.g. if you're using out/Default) On 2017/02/02 22:09:59, ...
3 years, 10 months ago (2017-02-02 22:29:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669593003/20001
3 years, 10 months ago (2017-02-02 22:31:01 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:33:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16c41931e1bcdcb640c5cd828502...

Powered by Google App Engine
This is Rietveld 408576698