Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2669563004: Add TEAM/COMPONENT to OWNERS (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TEAM/COMPONENT BUG=679905 R=lazyboy Review-Url: https://codereview.chromium.org/2669563004 Cr-Commit-Position: refs/heads/master@{#447932} Committed: https://chromium.googlesource.com/chromium/src/+/98d886ffe28bb64975dc49e7ac0d602a1860b6f5

Patch Set 1 #

Total comments: 15

Patch Set 2 : update compo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M chrome/browser/apps/guest_view/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/web_view/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_context_menu/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/guest_view/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/guest_view/common/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/guest_view/renderer/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/renderer_context_menu/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/browser_plugin/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/guest_view/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/api/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M extensions/common/guest_view/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/guest_view/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/resources/guest_view/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/test/data/web_view/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-01-31 21:23:00 UTC) #1
lazyboy
https://codereview.chromium.org/2669563004/diff/1/chrome/browser/renderer_context_menu/OWNERS File chrome/browser/renderer_context_menu/OWNERS (right): https://codereview.chromium.org/2669563004/diff/1/chrome/browser/renderer_context_menu/OWNERS#newcode4 chrome/browser/renderer_context_menu/OWNERS:4: # COMPONENT: Platform>Extensions>API This is chrome's right-click menu and ...
3 years, 10 months ago (2017-01-31 21:42:09 UTC) #3
ymzhang1
https://codereview.chromium.org/2669563004/diff/1/chrome/browser/renderer_context_menu/OWNERS File chrome/browser/renderer_context_menu/OWNERS (right): https://codereview.chromium.org/2669563004/diff/1/chrome/browser/renderer_context_menu/OWNERS#newcode4 chrome/browser/renderer_context_menu/OWNERS:4: # COMPONENT: Platform>Extensions>API On 2017/01/31 21:42:09, lazyboy wrote: > ...
3 years, 10 months ago (2017-01-31 22:12:15 UTC) #4
lazyboy
lgtm https://codereview.chromium.org/2669563004/diff/1/chrome/browser/renderer_context_menu/OWNERS File chrome/browser/renderer_context_menu/OWNERS (right): https://codereview.chromium.org/2669563004/diff/1/chrome/browser/renderer_context_menu/OWNERS#newcode4 chrome/browser/renderer_context_menu/OWNERS:4: # COMPONENT: Platform>Extensions>API On 2017/01/31 22:12:15, ymzhang1 wrote: ...
3 years, 10 months ago (2017-01-31 22:15:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669563004/20001
3 years, 10 months ago (2017-01-31 22:21:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/374124)
3 years, 10 months ago (2017-02-01 01:21:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2669563004/20001
3 years, 10 months ago (2017-02-02 23:21:14 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:28:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/98d886ffe28bb64975dc49e7ac0d...

Powered by Google App Engine
This is Rietveld 408576698