Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2669513002: Rotate frames according to camera orientation (Closed)

Created:
3 years, 10 months ago by wuchengli
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Rotate frames according to camera orientation Camera orientation information is available in camera_characteristics.conf file. When rotating frames, we should consider both the display rotation and the camera orientation in the config file. BUG=684375, chrome-os-partner:61414 TEST=On reef, verify that back camera shows correct preview when in tablet mode. Review-Url: https://codereview.chromium.org/2648743002 Cr-Commit-Position: refs/heads/master@{#446285} (cherry picked from commit 306b9e55cc83f18e30023e1af00f2f7abc649c6e) Review-Url: https://codereview.chromium.org/2669513002 . Cr-Commit-Position: refs/branch-heads/2987@{#213} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b460ef356c93f5784599315d097b3e557bd4ab23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -371 lines) Patch
M media/capture/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
A + media/capture/video/linux/camera_config_chromeos.h View 4 chunks +23 lines, -8 lines 0 comments Download
A + media/capture/video/linux/camera_config_chromeos.cc View 6 chunks +55 lines, -29 lines 0 comments Download
A + media/capture/video/linux/camera_config_chromeos_unittest.cc View 2 chunks +12 lines, -8 lines 0 comments Download
D media/capture/video/linux/camera_facing_chromeos.h View 1 chunk +0 lines, -81 lines 0 comments Download
D media/capture/video/linux/camera_facing_chromeos.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D media/capture/video/linux/camera_facing_chromeos_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M media/capture/video/linux/video_capture_device_factory_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wuchengli
3 years, 10 months ago (2017-01-31 03:02:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b460ef356c93f5784599315d097b3e557bd4ab23.

Powered by Google App Engine
This is Rietveld 408576698